From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alain Schneble Newsgroups: gmane.emacs.bugs Subject: bug#22789: 25.1.50; In last master build https connections stop working Date: Tue, 8 Mar 2016 17:43:20 +0100 Message-ID: <867fhczzrr.fsf@realize.ch> References: <864mcyo14y.fsf@Lenovo-PC.i-did-not-set--mail-host-address--so-tickle-me> <83io18ahya.fsf@gnu.org> <86y4a3on6f.fsf@realize.ch> <87oaazg7fv.fsf@gnus.org> <86twkro0vr.fsf@realize.ch> <83d1rf8ifj.fsf@gnu.org> <86povfnm9r.fsf@realize.ch> <8337sa9865.fsf@gnu.org> <86bn6ynrbw.fsf@realize.ch> <83vb566v5b.fsf@gnu.org> <83d1razkmq.fsf@gnu.org> <86egbqkwsb.fsf@realize.ch> <86a8mekjrb.fsf@realize.ch> <83k2lhxria.fsf@gnu.org> <86egbo232a.fsf@realize.ch> <83si04wx18.fsf@gnu.org> <8660wz1azm.fsf@realize.ch> <861t7n1970.fsf@realize.ch> <83mvqauv8l.fsf@gnu.org> <86bn6qylmj.fsf@realize.ch> <83y49srkin.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457455463 1578 80.91.229.3 (8 Mar 2016 16:44:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 16:44:23 +0000 (UTC) Cc: larsi@gnus.org, j_l_domenech@yahoo.com, 22789@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 08 17:44:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adKk1-0000lZ-00 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Mar 2016 17:44:13 +0100 Original-Received: from localhost ([::1]:35847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKk0-0007PG-El for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Mar 2016 11:44:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKjt-0007Oc-Q2 for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:44:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKjq-0005ZP-26 for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:44:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKjp-0005ZE-VP for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1adKjp-0002zF-Kl for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alain Schneble Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Mar 2016 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22789-submit@debbugs.gnu.org id=B22789.145745542411448 (code B ref 22789); Tue, 08 Mar 2016 16:44:01 +0000 Original-Received: (at 22789) by debbugs.gnu.org; 8 Mar 2016 16:43:44 +0000 Original-Received: from localhost ([127.0.0.1]:39930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adKjX-0002ya-8Y for submit@debbugs.gnu.org; Tue, 08 Mar 2016 11:43:44 -0500 Original-Received: from clientmail.realize.ch ([46.140.89.53]:1629) by debbugs.gnu.org with smtp (Exim 4.84) (envelope-from ) id 1adKjR-0002yE-Lp for 22789@debbugs.gnu.org; Tue, 08 Mar 2016 11:43:41 -0500 Original-Received: from rintintin.hq.realize.ch.lan.rit ([192.168.0.105]) by clientmail.realize.ch ; Tue, 8 Mar 2016 17:43:11 +0100 Original-Received: from MYNGB (192.168.66.64) by rintintin.hq.realize.ch.lan.rit (192.168.0.105) with Microsoft SMTP Server (TLS) id 15.0.516.32; Tue, 8 Mar 2016 17:43:11 +0100 In-Reply-To: <83y49srkin.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Mar 2016 18:40:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) X-ClientProxiedBy: rintintin.hq.realize.ch.lan.rit (192.168.0.105) To rintintin.hq.realize.ch.lan.rit (192.168.0.105) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114582 Archived-At: Eli Zaretskii writes: >> From: Alain Schneble >> CC: , , <22789@debbugs.gnu.org> >> Date: Mon, 7 Mar 2016 23:21:56 +0100 >> >> > So we should only return EWOULDBLOCK when FILE_CONNECT is set _and_ >> > the status is not STATUS_CONNECT_FAILED. If FILE_CONNECT is set, but >> > the status is STATUS_CONNECT_FAILED, we should instead return the >> > value computed from cp->errcode (if it is non-zero). There's an >> > example of that in sys_read. >> >> Thank you very much for these inputs. I rearranged the patch to include >> these two cases and removed another special case that should no longer >> be needed as it is covered by the first one. >> >> Is this what you had in mind? Do you agree with the change? > > Yes, it looks good to me. I will test it in a couple of days. Thank you, Eli.