bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Jean Louis]

I have noticed, but have not researched why, is that function
`sql-list-tables' takes indefinite time without completing or giving
result when I do following:

- M-x sql-postgres RET and more entries until I get into the SQL buffer

- create new table

- C-c C-l t with new table name is then taking indefinite time.

Maybe the library is reading tables only at initializations, I may be
wrong. In SQL buffer there is no problem to inspect the table, but C-c
C-l t does not allow it for new table created.

This may all be wrong and related to some other bug there, I do not
know. I was interrupting the indefinite message with C-g.



In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.4, Xaw scroll bars)
 of 2021-03-22 built on protected.rcdrun.com
Repository revision: cb5d1fe1aa9f280d60fcb33b58fc83ace3d95081
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
Configured using:
 'configure --with-x-toolkit=lucid'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM
LUCID ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=exwm-xim
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 56355 6695)
 (symbols 48 7105 0)
 (strings 32 20372 1235)
 (string-bytes 1 656059)
 (vectors 16 14408)
 (vector-slots 8 192257 13655)
 (floats 8 23 38)
 (intervals 56 251 0)
 (buffers 992 12))

-- 
Thanks,
Jean Louis
⎔ λ 🄯 𝍄 𝌡 𝌚

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Stefan Kangas]

Jean Louis <bugs@gnu.support> writes:

> I have noticed, but have not researched why, is that function
> `sql-list-tables' takes indefinite time without completing or giving
> result when I do following:
>
> - M-x sql-postgres RET and more entries until I get into the SQL buffer
>
> - create new table
>
> - C-c C-l t with new table name is then taking indefinite time.
>
> Maybe the library is reading tables only at initializations, I may be
> wrong. In SQL buffer there is no problem to inspect the table, but C-c
> C-l t does not allow it for new table created.
>
> This may all be wrong and related to some other bug there, I do not
> know. I was interrupting the indefinite message with C-g.

I'm copying in the sql.el maintainer here.  Michael, could you please
take a look at the above bug report?

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Thursday, October 21st, 2021 at 5:02 PM, Stefan Kangas <stefan@marxist.se> wrote:
> Jean Louis bugs@gnu.support writes:
>
> > I have noticed, but have not researched why, is that function
> > `sql-list-tables' takes indefinite time without completing or giving
> > result when I do following:
> >
> > -   M-x sql-postgres RET and more entries until I get into the SQL buffer
> > -   create new table
> > -   C-c C-l t with new table name is then taking indefinite time.
> >
> > Maybe the library is reading tables only at initializations, I may be
> > wrong. In SQL buffer there is no problem to inspect the table, but C-c
> > C-l t does not allow it for new table created.
> >
> > This may all be wrong and related to some other bug there, I do not
> > know. I was interrupting the indefinite message with C-g.
>
> I'm copying in the sql.el maintainer here. Michael, could you please
> take a look at the above bug report?

The problem here is that the `sql-list-tables' feature uses the
`comint-redirect-send-command-to-process' procedure to capture the SQL
interpreter response and that relies upon the `comint-prompt-regexp'
variable to be set appropriately. Comint Mode itself no longer relies
upon the regexp to spot the prompt but the redirect logic does.

The default prompt regexp for Postgres in sql.el is not correct and a
fix will be made for Emacs 28 and master for that.

I will also add a function to sql.el to verify the prompt as best I can
to Emacs-28 so at least an error message or workaround can be provided.

On master, I'll submit a similar change to comint.el to protect all
Comint derived modes if they use the redirect logic and prevent the
hanging behavior.

I was aware of the bad prompt regexp but had forgotten to commit that
change. I'll go ahead and do that now.
--
MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Stefan Kangas]

Michael Mauger <mmauger@protonmail.com> writes:

> I was aware of the bad prompt regexp but had forgotten to commit that
> change. I'll go ahead and do that now.

Thank you for looking into this.  I think these fixes will be much
appreciated by our postgres users out there.

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Lars Ingebrigtsen]

Michael Mauger <mmauger@protonmail.com> writes:

> The default prompt regexp for Postgres in sql.el is not correct and a
> fix will be made for Emacs 28 and master for that.
>
> I will also add a function to sql.el to verify the prompt as best I can
> to Emacs-28 so at least an error message or workaround can be provided.
>
> On master, I'll submit a similar change to comint.el to protect all
> Comint derived modes if they use the redirect logic and prevent the
> hanging behavior.
>
> I was aware of the bad prompt regexp but had forgotten to commit that
> change. I'll go ahead and do that now.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

This was some months ago, and I had a look at the commit log for sql.el
now, but it doesn't look like this change was pushed?  (But I may be
looking for the wrong thing here.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors]

I think the fix got pushed to 27 but I never cherry-picked it for 28.  (It's been a tough Spring, hopefully settling down now)

However, this with the `sql-interactive-remove-continuation-prompt`changes seem to have caused some issues which I am debugging.

--
MICHAEL@MAUGER.COM // FSF and SFConservancy // GNU Emacs sql.el maintainer

------- Original Message -------
On Sunday, June 26th, 2022 at 2:32 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:


> Michael Mauger mmauger@protonmail.com writes:
>
> > The default prompt regexp for Postgres in sql.el is not correct and a
> > fix will be made for Emacs 28 and master for that.
> >
> > I will also add a function to sql.el to verify the prompt as best I can
> > to Emacs-28 so at least an error message or workaround can be provided.
> >
> > On master, I'll submit a similar change to comint.el to protect all
> > Comint derived modes if they use the redirect logic and prevent the
> > hanging behavior.
> >
> > I was aware of the bad prompt regexp but had forgotten to commit that
> > change. I'll go ahead and do that now.
>
>
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> This was some months ago, and I had a look at the commit log for sql.el
> now, but it doesn't look like this change was pushed? (But I may be
> looking for the wrong thing here.)
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no

bug#47357: 28.0.50; sql-list-tables: Executing SQL command... takes indefinite time after creation of new table

[Lars Ingebrigtsen]

Michael Mauger <mmauger@protonmail.com> writes:

> I think the fix got pushed to 27 but I never cherry-picked it for 28.

I think all fixes to Emacs 27 should have been included in Emacs 28
automatically... 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no