From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add outline regexp to ruby-mode Date: Wed, 06 Jul 2022 11:06:18 +0300 Organization: LINKOV.NET Message-ID: <867d4qvep9.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22334"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: "Emacs Devel" To: "Bozhidar Batsov" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 06 10:21:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o90HQ-0005g6-1z for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jul 2022 10:21:04 +0200 Original-Received: from localhost ([::1]:47184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o90HO-0003Eu-Ky for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jul 2022 04:21:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o90Fj-000256-S2 for emacs-devel@gnu.org; Wed, 06 Jul 2022 04:19:20 -0400 Original-Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:54299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o90Fh-000702-SQ for emacs-devel@gnu.org; Wed, 06 Jul 2022 04:19:19 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2BD57E0002; Wed, 6 Jul 2022 08:19:09 +0000 (UTC) In-Reply-To: (Bozhidar Batsov's message of "Wed, 06 Jul 2022 10:04:49 +0300") Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291899 Archived-At: >> Some programming modes built into emacs provide outline-regexp to >> allow for code folding and an example of this is python-mode. >> "ruby-mode" on the other hand does does not have this feature. Since >> it is a very handy feature to have it might be worth adding with the >> following simple patch. >> >> - (setq-local syntax-propertize-function #'ruby-syntax-propertize)) >> + (setq-local syntax-propertize-function #'ruby-syntax-propertize) >> + (setq-local outline-regexp ruby-indent-beg-re)) > > I like this suggestion, although I don't think that's the right regexp to > use for an outline. Shouldn't it be limited to definitions only (similar to > what imenu typically does)? I have been successfully using outlines in ruby-mode for a long time with such simple customization because I didn't want to make outlines on if/unless/case/..., only on definitions class/module/def. (add-hook 'ruby-mode-hook (lambda () ;; Copied some keywords from ‘ruby-block-beg-keywords’ and ;; ‘ruby-imenu-create-index-in-block’ (setq-local outline-regexp (concat "^\\s *" (regexp-opt '("class" "module" "def")) "\\s +")) (setq-local outline-level (lambda () (1+ (/ (current-indentation) ruby-indent-level)))) (outline-minor-mode +1))) But now I noticed that actually if/unless/case/... in ruby-indent-beg-re has no effect on outlines, because they are on a separate regexp group. So using it for outline-regexp would be fine. Then I only suggest to add outline-level as well.