From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68824: treesitter support for outline-minor-mode Date: Mon, 12 Feb 2024 14:59:03 +0200 Message-ID: <867cj9suso.fsf@gnu.org> References: <86le8667u7.fsf@mail.linkov.net> <865xza39vp.fsf@gnu.org> <86y1c6q7oh.fsf@mail.linkov.net> <86mssbbdz5.fsf@mail.linkov.net> <86zfwbwe7a.fsf@gnu.org> <86v86z9e4u.fsf@mail.linkov.net> <86eddmwzs0.fsf@gnu.org> <865xyykvp3.fsf@mail.linkov.net> <86sf21v3rj.fsf@gnu.org> <864jeg8dch.fsf@mail.linkov.net> <86jznctd6p.fsf@gnu.org> <86le7qykec.fsf@mail.linkov.net> <86cyt2st5g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37753"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68824@debbugs.gnu.org, juri@linkov.net To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 14:00:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZVvD-0009YK-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 14:00:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZVuf-0007Cy-3s; Mon, 12 Feb 2024 07:59:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZVuV-0007CQ-Ox for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 07:59:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZVuU-0002Ps-IG for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 07:59:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZVul-00039o-1V for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 08:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68824-submit@debbugs.gnu.org id=B68824.170774277711984 (code B ref 68824); Mon, 12 Feb 2024 13:00:02 +0000 Original-Received: (at 68824) by debbugs.gnu.org; 12 Feb 2024 12:59:37 +0000 Original-Received: from localhost ([127.0.0.1]:55179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZVuL-00037D-FV for submit@debbugs.gnu.org; Mon, 12 Feb 2024 07:59:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZVuJ-00036h-9k for 68824@debbugs.gnu.org; Mon, 12 Feb 2024 07:59:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZVtw-0002La-Vk; Mon, 12 Feb 2024 07:59:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KubOjeCt9lTnGeC93iOHtbZ2A4pShSGGG9j9+ucGhTA=; b=qbCekoyhnoirMdvXRmu2 3g4abGuOdmMALtKQnNzNoNN42ejyu1LkPes8oavjcCWR2fif55nlPiW3V3eJSOxf8k1clNLoc4hVK vMfj7WimtiMWEFxmcDiIonl1XB3hszqgvjpHx5TRoM+RcvT0U9wtSOST5EQVZkjKtSfa2DiDx9Kd2 U7mDJJvYnVUAaIzsfoGKRgq+oPjdfqLpxSqaPdBZDZLu8cYUyelxSWtHV4+98KairK9Z5nZSKWWSZ fLWjtNzbH6aqbro2L78rsfXkjbgP6DuS+kWwoaP+i+S/ISZ9Cy5Q/SMYwO8rom8flChY/ulcQ1OfZ sMFK14hm5/Xq8w==; In-Reply-To: (message from Yuan Fu on Sun, 11 Feb 2024 17:07:00 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279891 Archived-At: > From: Yuan Fu > Date: Sun, 11 Feb 2024 17:07:00 -0800 > Cc: Juri Linkov , > 68824@debbugs.gnu.org > > >>> Then maybe just move the text about outline-search-function to the > >>> place where you describe treesit-outline-predicate? > >> > >> 'outline-search-function' is unsuitable for "Tree-sitter Major Modes". > > > > All of this thread clearly indicates otherwise. > > The real problem is probably that outline-minor-mode’s api wasn’t described in the Elisp manual (Imenu, OTOH, has a node in Elisp manual). I think we can create a node for outline in (elisp)Modes (that’s where the node for Imenu is). We can start out with only outline-search-function in there, and over time populate it with outline-level, outline-regexp, etc. That'd be fine by me. But since Juri said he was uncomfortable with such a short node, I tried to suggest alternative ideas. If having a short new node is deemed our best option, then let's do that. We could also have a node for importand minor modes (as opposed to having a separate node for each such minor mode). > If in the future we add language-agnostic features similar to outline and imenu, which needs major mode integration, (elisp)Modes would be a good place to document them. Right.