From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted Date: Tue, 18 Jun 2024 15:58:45 +0300 Message-ID: <867cemquey.fsf@gnu.org> References: <86tthzwgsw.fsf@mail.linkov.net> <86msnkyt7c.fsf@mail.linkov.net> <30404984-e7ac-4f92-a194-06438dbf2d03@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 71466@debbugs.gnu.org, juri@linkov.net To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 18 14:59:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJYQT-0001Gr-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Jun 2024 14:59:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJYQO-0008Rs-Me; Tue, 18 Jun 2024 08:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJYQN-0008Rj-Bf for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 08:58:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJYQN-0007Yo-4M for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 08:58:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJYQP-0002GE-MP for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 08:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jun 2024 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71466 X-GNU-PR-Package: emacs Original-Received: via spool by 71466-submit@debbugs.gnu.org id=B71466.17187155418686 (code B ref 71466); Tue, 18 Jun 2024 12:59:01 +0000 Original-Received: (at 71466) by debbugs.gnu.org; 18 Jun 2024 12:59:01 +0000 Original-Received: from localhost ([127.0.0.1]:42217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJYQO-0002Fz-Q1 for submit@debbugs.gnu.org; Tue, 18 Jun 2024 08:59:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJYQM-0002Fk-W4 for 71466@debbugs.gnu.org; Tue, 18 Jun 2024 08:58:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJYQE-0007YC-F2; Tue, 18 Jun 2024 08:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=abnIigZS1crQS6qQxp8GC4kFiL8JAksIZvN/iSM3HtE=; b=lVkibdddQDa4 g2MffxvVJrnWp2jQtsKS9PjX4y3VKHdNl9LNfpnmMe9m7qMe5xI49C4W45FmkoZMheVT0RrBzt4zm BUrQIlW+3aVV5DC6fje+kJO6imp3/etzNiM0VSilFPl58UymfwocO3387vZI5i3UIc8bhqXUMi3gu qDum+R3Uyo+FdLRFcq0R7SdVMVotPXWvaaXqaRHo3SmnbLcdVwiIYrI0qFaxUkhBeR07JIsjUTVcd FHLGuz+PTYP3li1Ahg9ROCZWCDP01xCOAc2m9phgM+Wsv9n5ySxeaa+pHjJz0MENM5SeOOELPm73U RJ056eUag55TUT+kAa1fTQ==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287437 Archived-At: > Cc: 71466@debbugs.gnu.org, Juri Linkov > Date: Tue, 18 Jun 2024 09:00:38 +0200 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > @item g > -@findex xref-revert-buffer > -Refresh the contents of the @file{*xref*} buffer > -(@code{xref-revert-buffer}). > +Refresh the contents of the @file{*xref*} buffer (@code{revert-buffer}). > +@xref{Reverting}. Why remove the index entry? It needs to be rewritten, not removed. > +** Xref > + > +*** 'xref-revert-buffer' is obsolete, prefer 'revert-buffer' instead. > +The former is now an alias of the latter. The Xref results buffer sets Please use "The Xref buffer". "The Xref results buffer" reads awkwardly, and there actually is no such thing as "Xref results". > @@ -1011,6 +1010,7 @@ xref--xref-buffer-mode > #'xref--imenu-extract-index-name) > (setq-local add-log-current-defun-function > #'xref--add-log-current-defun) > + (setq-local revert-buffer-function #'xref--revert-buffer) > (setq-local outline-minor-mode-cycle t) > (setq-local outline-minor-mode-use-buttons 'insert) > (setq-local outline-search-function > @@ -1273,22 +1273,16 @@ xref--show-common-initialize > xref--original-window-intent (assoc-default 'display-action alist)) > (setq xref--fetcher fetcher))) > > -(defun xref-revert-buffer () > +(defun xref--revert-buffer (&rest _) ; Ignore `revert-buffer' args. > "Refresh the search results in the current buffer." And I wonder why you preferred a backward-incompatible change to a backward-compatible one: leave the function's name alone, and just set up revert-buffer-function to invoke it. Was this not possible for some technical reason that evades me?