From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Date: Wed, 19 Jun 2024 16:12:05 +0300 Message-ID: <867celoz4q.fsf@gnu.org> References: <87plsdxhnw.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25638"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71648@debbugs.gnu.org To: Robert Pluim , justin@burkett.cc, Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 19 15:13:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJv7l-0006Jq-02 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jun 2024 15:13:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJv7V-0006X1-AX; Wed, 19 Jun 2024 09:13:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJv7T-0006Vq-8u for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 09:12:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJv7S-0004SP-VP for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 09:12:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJv7V-000839-U1 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 09:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs Original-Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171880274130879 (code B ref 71648); Wed, 19 Jun 2024 13:13:01 +0000 Original-Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 13:12:21 +0000 Original-Received: from localhost ([127.0.0.1]:43286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJv6q-00081z-QK for submit@debbugs.gnu.org; Wed, 19 Jun 2024 09:12:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJv6o-00081h-AV for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 09:12:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJv6f-0004Mo-8r; Wed, 19 Jun 2024 09:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5vAWCOaNs7X3ALO7b1Gc1KJ8H4rWZI7SCiDyaOAsPWQ=; b=UsyPt+55UOq/ CLFcJdsu5k/jbSiDYrJJmox2JamkRgxpRRcAh8fpRHkyPPBn4eBxoz9r1W53HeYwaHFtCmQ1srmTb YCn2Fz+3TH5aOaIS+pmosB0YDl3HAfkMG7miouBBf4Lw/QcxkxyR7DkYhDOpBYboyj95PlV3fffN3 glG+Nv2yPmdE3Uc1wz2LaLRuG3k8+84JYR1rGkTOex1mmjL5ONebv3XyKhvdzZ5da7XCg6Lmc9UDJ 6C8/9RaPQXmYHBKx4jWlg7ndpWy4QosCVLGtstTi7mq0gLqSCF/ha8aDUI19xt2ytERrTQvWMPAIt Uw59hmBzu5OtmPTwv8ubVQ==; In-Reply-To: <87plsdxhnw.fsf@gmail.com> (message from Robert Pluim on Wed, 19 Jun 2024 14:04:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287482 Archived-At: > From: Robert Pluim > Date: Wed, 19 Jun 2024 14:04:35 +0200 > > `which-key-mode' currently only looks at keymaps, not translation > keymaps such as `key-translation-map' and `function-key-map'. In order > to aid discoverability, perhaps it should do the following > > (maybe with a user option) > > @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings > > (defun which-key--get-current-bindings (&optional prefix filter) > "Generate a list of current active bindings." > - (let (bindings) > - (dolist (map (current-active-maps t) bindings) > + (let (bindings > + (maps (nconc (current-active-maps t) > + (list key-translation-map function-key-map)))) > + (dolist (map maps bindings) > (when (cdr map) > (setq bindings > (which-key--get-keymap-bindings > Let's have the relevant people on-board of this discussion.