From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: remove-overlays test [was: * lisp/hi-lock.el: More fixes for revert-buffer (bug#57534)] Date: Fri, 28 Jun 2024 09:43:30 +0300 Organization: LINKOV.NET Message-ID: <867ce98t4d.fsf_-_@mail.linkov.net> References: <171951175019.5752.4559993590758222831@vcs2.savannah.gnu.org> <20240627180913.2E298C1FB74@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20159"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 28 08:45:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sN5Mb-00056N-35 for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jun 2024 08:45:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sN5Lt-0004aI-4C; Fri, 28 Jun 2024 02:44:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN5Ls-0004a5-6n for emacs-devel@gnu.org; Fri, 28 Jun 2024 02:44:56 -0400 Original-Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN5Lp-00077l-Vq; Fri, 28 Jun 2024 02:44:55 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id D431DFF807; Fri, 28 Jun 2024 06:44:49 +0000 (UTC) In-Reply-To: (Andrea Corallo's message of "Thu, 27 Jun 2024 15:03:32 -0400") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320800 Archived-At: > just to mention this is causing a regression on my testbench: Thanks for the heads-up. The problem is that in 'remove-overlays' values are compared with 'eq', and there is no way to specify another test function. This important detail is still missing in (info "(elisp) Managing Overlays") (this could be added now), whereas the docstring was updated recently via bug#13648. This example demonstrates the problem: (with-temp-buffer (insert "str") (let ((prop "a") (ov (make-overlay (point-min) (point-max)))) (overlay-put ov 'prop prop) (remove-overlays nil nil 'prop prop) (overlays-in (point-min) (point-max)))) => nil (with-temp-buffer (insert "str") (let ((ov (make-overlay (point-min) (point-max)))) (overlay-put ov 'prop "a") (remove-overlays nil nil 'prop "a") (overlays-in (point-min) (point-max)))) => (#) So this is fixed now by using the same string for 'eq'.