From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71929: 30.0.60; crash in mark_image_cache Date: Fri, 05 Jul 2024 14:10:12 +0300 Message-ID: <867ce06qnf.fsf@gnu.org> References: <87jzi17uot.fsf@melete.silentflame.com> <87y16h6fm3.fsf@melete.silentflame.com> <86jzi1aeje.fsf@gnu.org> <86ikxlae3p.fsf@gnu.org> <87tth4ofvp.fsf@melete.silentflame.com> <86jzi073r8.fsf@gnu.org> <871q4849yc.fsf@yahoo.com> <86frso70i4.fsf@gnu.org> <87wmm02n9q.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71929@debbugs.gnu.org, spwhitton@spwhitton.name To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 13:11:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPgqX-0007lS-Bi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 13:11:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPgqC-0004n9-W3; Fri, 05 Jul 2024 07:11:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPgqB-0004mo-6R for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 07:10:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPgqA-00055s-UH for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 07:10:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPgqD-0000Uq-Ka for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 07:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71929 X-GNU-PR-Package: emacs Original-Received: via spool by 71929-submit@debbugs.gnu.org id=B71929.17201778281857 (code B ref 71929); Fri, 05 Jul 2024 11:11:01 +0000 Original-Received: (at 71929) by debbugs.gnu.org; 5 Jul 2024 11:10:28 +0000 Original-Received: from localhost ([127.0.0.1]:43647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPgpg-0000Tt-DH for submit@debbugs.gnu.org; Fri, 05 Jul 2024 07:10:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPgpd-0000TX-Ms for 71929@debbugs.gnu.org; Fri, 05 Jul 2024 07:10:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPgpV-00051n-99; Fri, 05 Jul 2024 07:10:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0PIRtfdVOGzsYOUsbNe3+V1JHs5+JjB1l/WJI+kGOqE=; b=j/EjQY+kxOlK YDGJu42VOjYWZ7snKWSlZ9mLZXyKYw4QT91QnYa4+Q+hpeOaMrF80klSqwbN6z/nvr3ZyvFGZozwS ZgbSgaOa6KkwRjZ9I67RZUCiRHgOeBsWguwz5+NxJx8fuqo+MzezM16/e3u24XawysBmvJR7sd+6Q VKdfehgkJEd8M7kFerKrzVIah0uEY5xS5ZTCkj7/Eu8/hAUCYd6oTYwpv3Inj2Um3w/4rkdg9Kut/ D7jnbCFLtuj0oX4v3hWh73p4wCFfT4aqHXZFLxfvsEt7VSQIhgDhQ4FlNlf6eAEUmuBx4++AilZKB 4mPDg+4GcA5IpdIejfza1Q==; In-Reply-To: <87wmm02n9q.fsf@yahoo.com> (message from Po Lu on Fri, 05 Jul 2024 17:36:49 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288418 Archived-At: > From: Po Lu > Cc: spwhitton@spwhitton.name, 71929@debbugs.gnu.org > Date: Fri, 05 Jul 2024 17:36:49 +0800 > > Eli Zaretskii writes: > > > How does this answer my question? > > I mentioned free_frame_faces. That's the only function where image > caches are released. > > > The use case I was thinking of is that the image cache was shared, > > then the last frame which shared the cache was deleted. How do we > > make sure the cache is freed and set to NULL in this situation? > > The cache (whose refcount is 1) is released in free_frame_faces when it > is called with this final frame, through free_image_cache, which also > resets its `FRAME_IMAGE_CACHE' to NULL. > > > IOW, we seem to have a cache that is not NULL but is also not a real > > cache, as it cannot be accessed. The question is how did that happen? > > I don't know. It can only be the case if its `refcount' was decremented > excessively for a reason not yet understood. Can you suggest a GDB setup for Sean to use in order to try to find this unknown code which causes this? Please note that this affects the release branch, and the changeset which seems to have caused it was installed a couple of days before the release branch was cut. So if we cannot find and solve the problem soon enough, I'd revert that changeset and solve the original problem which it was supposed to solve on master, rather than leave such a serious problem on the release branch.