From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>, damien@cassou.me
Cc: 71776@debbugs.gnu.org, v.pupillo@gmail.com
Subject: bug#71776: 31.0.50; [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc.
Date: Sat, 06 Jul 2024 10:54:11 +0300 [thread overview]
Message-ID: <867cdz5524.fsf@gnu.org> (raw)
In-Reply-To: <beac41b3-42e6-47e8-8540-98c659cc075a@gutov.dev> (message from Dmitry Gutov on Fri, 28 Jun 2024 03:50:10 +0300)
Ping! Damien, would you please chime in and comment on the patch?
> Date: Fri, 28 Jun 2024 03:50:10 +0300
> Cc: 71776@debbugs.gnu.org, Damien Cassou <damien@cassou.me>
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> Hi!
>
> On 27/06/2024 12:47, Eli Zaretskii wrote:
> >> From: Vincenzo Pupillo<v.pupillo@gmail.com>
> >> Date: Tue, 25 Jun 2024 16:16:21 +0200
> >>
> >> The use of font lock faces by jsdoc in js-ts-mode is different from that done in
> >> other major-modes such as java-mode or c++-mode. This patch makes them more similar.
> > Thanks.
> >
> > Dmitry, any comments? On which branch should we install this, if you
> > agree with the changes?
>
> It looks like an improvement (thanks!), and as a change to the feature
> added just recently, should go to emacs-30 - the second revision of the
> patch, naturally.
>
> Also Cc'ing Damien who did the original work.
next prev parent reply other threads:[~2024-07-06 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 14:16 bug#71776: 31.0.50; [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc Vincenzo Pupillo
2024-06-27 9:47 ` Eli Zaretskii
2024-06-27 10:33 ` Vincenzo Pupillo
2024-06-27 19:20 ` Vincenzo Pupillo
2024-06-28 0:50 ` Dmitry Gutov
2024-07-06 7:54 ` Eli Zaretskii [this message]
2024-07-06 8:51 ` Damien Cassou
2024-07-06 10:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cdz5524.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71776@debbugs.gnu.org \
--cc=damien@cassou.me \
--cc=dmitry@gutov.dev \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.