From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable Date: Wed, 21 Aug 2024 16:51:13 +0300 Message-ID: <867ccaugq6.fsf@gnu.org> References: <86plq3uib0.fsf@gnu.org> <87seuyh2p0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bjorn.bidar@thaodan.de, 72735@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 21 15:52:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgllG-0005Jp-84 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Aug 2024 15:52:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgll5-0005KC-62; Wed, 21 Aug 2024 09:52:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgll4-0005Jq-4a for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 09:52:18 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgll3-0005Tv-S0 for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 09:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=D76r9fonHcYyHMw4nQAAQaSecpX2fyDijmCTNWHnU9A=; b=Ii5c0BArVYHYHyiEIj+o5nPuZfY/rp6Xhq0U0E/PjkvNfcTXprDe8JMCPPPcEHFgMQMiCJLgtWIFXrx/IP0uw0CzEDelisYoBKUzP906dv33f2CtD95NVlyuPKizADm2pzvh13fCTN4vSocIPmvEwZsggAfAr0L/zDrrAM9W2TgCh6vXLqrjiWjI/e9kt9rF6ws3ngNj80n/8EOHaJcD+KUcdFxG4whzwH+en2n3lQMiBRn5BugQ4vaeaxHLC+98joi/caJa/FoHIJimeuwT6rRQQ1Ui8RYFc2YeU3VfISaDg5z9g2hkzkGluXRHPr7cCu2c5M8ap89wQD5LNElmQA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgllm-0003iR-1O for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 09:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2024 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72735 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72735-submit@debbugs.gnu.org id=B72735.172424833614197 (code B ref 72735); Wed, 21 Aug 2024 13:53:02 +0000 Original-Received: (at 72735) by debbugs.gnu.org; 21 Aug 2024 13:52:16 +0000 Original-Received: from localhost ([127.0.0.1]:35233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgll1-0003gu-Kz for submit@debbugs.gnu.org; Wed, 21 Aug 2024 09:52:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sglkz-0003gb-WF for 72735@debbugs.gnu.org; Wed, 21 Aug 2024 09:52:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sglkB-00056X-VA; Wed, 21 Aug 2024 09:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=D76r9fonHcYyHMw4nQAAQaSecpX2fyDijmCTNWHnU9A=; b=N9AzE5at8wSK9oVxF3fG nYSGnW5uyta0LQGCrRo8FWNSQMOwkOHiaROCTrcp1TDBcdrYgh3/so4eVnwxzo0tLpOVns9xuNWMB kPmtCECwIkRqZn1IaFykbFDrK6XP6ZjnVhExwNd2x6X1MFf259RlTCAHhylxdPmt5/6TTMUr6YMdp byR+pG8x1hpzRboaLkApRGA8zYY+jkY+84m81GykZK+OnNqcQCES+geg64+ru6dBrvhov3WjwxzD9 9tqiqhGfGnoDGIEV4leqlNDDOkPg+RsDKhLrMrombzgWyMW/10KrHDmvvHbcterGCKE+59FCRsO/Q Y1mvBXCRbwVmFA==; In-Reply-To: <87seuyh2p0.fsf@gnu.org> (message from Tassilo Horn on Wed, 21 Aug 2024 07:20:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290493 Archived-At: > From: Tassilo Horn > Cc: Björn Bidar , > 72735@debbugs.gnu.org > Date: Wed, 21 Aug 2024 07:20:27 +0200 > > As Eli already mentioned, bug-reference-url-format is usually set via a > file local variables section or programatically so neither a defcustom > nor a default value makes sense. > > Wrt. bug-reference-setup-from-mail-alist, > bug-reference-setup-from-irc-alist, and > bug-reference-setup-from-vc-alist: yes, they could be defcustoms but > their entries can all (and are likely to) contain functions which are > hard to specify in the defcustom interface. I've thought it wouldn't be > needed. After all, bug-reference is a programmer's tool. > > Wrt. bug-reference-forge-alist: if it became a defcustom and a user > would set it, she wouldn't see updates (like support for some new forge) > in its default value anymore because their old saved custom value > overrides the new default value. It's much better to add new entries > programatically using add-to-list or push/cl-pushnew. Of course, one > could split the variable in some *-default-alist defvar and a defcustom > *-alist where the latter is meant for user customization but I think > it's not worth the added complexity here. > > So I'd rather keep it as-is. Thanks. So, Björn, now you get to try to convince Tassilo that making some of these variables defcustoms does make sense. IOW, what are the problems in the current situation that prompted you to suggest these changes?