From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72692: Emacs 31.05 (40eecd594ac) get SIGSEGV on Linux (Linux 6.6.45 Kde Wayland) Date: Sat, 24 Aug 2024 12:09:09 +0300 Message-ID: <867cc6nv7u.fsf@gnu.org> References: <8b1c8e1f-e0b9-4049-888c-3f723e0008a9@gmail.com> <87plq5g1fo.fsf@protonmail.com> <86v7zxy8ur.fsf@gnu.org> <87ttfhdo1e.fsf@protonmail.com> <86jzgcycla.fsf@gnu.org> <87frr0eiyy.fsf@protonmail.com> <868qwsy40c.fsf@gnu.org> <87y14sd07m.fsf@protonmail.com> <86zfp8wlrv.fsf@gnu.org> <87cym4cvyo.fsf@protonmail.com> <86wmkcwj9c.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12083"; mail-complaints-to="usenet@ciao.gmane.io" Cc: execvy@gmail.com, 72692-done@debbugs.gnu.org To: pipcet@protonmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 24 11:12:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shmpC-00032k-Lo for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Aug 2024 11:12:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shmoi-0002cA-Vi; Sat, 24 Aug 2024 05:12:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shmog-0002bm-Fq for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 05:12:14 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shmog-0004Gb-6K for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 05:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=6QrVKvEU0dKBZ8SJunh4VOWR0jI/u7GK/IRXckmLHic=; b=iTlpDoeQ1vHHZu9ZDvAFo7K3pry0O8/ij+dfbTCJvL5tOllDB7oOB8d1C9fwIQX+G8oWOcxkZl0wA+gcZdlUGBrGJiqN1T2Ie6nfmuqppCSvyVlDxbVKInQ+ooULpACKn9MTnu3a1vi2JIpZyMnYx19PQlBeitoktvh65QY+j73xJJqt3Z20lwa8A98uxGF2kABggDcMjwzIPD5+7GEP50RqoSpi6N10NEbjyek6B0jk0yCuGroYJzeNhER+D9F/cnzMbt4g9++/wOu1VA88WR/bBaHIrMxeReX3m/MnwcklCwKNsnzysX6Zu+VHTJe+uOITDc5rHRDArYX8CRv9eg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shmpS-0008Ai-97 for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 05:13:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2024 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72692 X-GNU-PR-Package: emacs Mail-Followup-To: 72692@debbugs.gnu.org, eliz@gnu.org, execvy@gmail.com Original-Received: via spool by 72692-done@debbugs.gnu.org id=D72692.172449074031348 (code D ref 72692); Sat, 24 Aug 2024 09:13:02 +0000 Original-Received: (at 72692-done) by debbugs.gnu.org; 24 Aug 2024 09:12:20 +0000 Original-Received: from localhost ([127.0.0.1]:40468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shmol-00089Y-Mc for submit@debbugs.gnu.org; Sat, 24 Aug 2024 05:12:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shmoh-00089D-As for 72692-done@debbugs.gnu.org; Sat, 24 Aug 2024 05:12:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shmlj-0003hl-UL; Sat, 24 Aug 2024 05:09:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6QrVKvEU0dKBZ8SJunh4VOWR0jI/u7GK/IRXckmLHic=; b=Zmj9/gbQeilA fglBgh+S3SwLdw1jJoIbfeT2vgzckiguDi/eh/zY+1nSApiZvJcbS+JXkwqGVsDOdeqJEGKddtr04 ypsfSq45KVAiJvDyc7dPh8Xf0xPVLVTBpOZZg5yE5mElXOjDvmTeDjFhhEz7TDOMCuST51cwMx7f3 ckT3wwn7/9a3huM/11PC8wY8COkHE5RzcoyioMlDAM6SFvj9IxTixSAawXyXBgAHQcDiqbDXsqRp4 4m7H2kyanMDB1W4AApq6W1ivlO2UjeNdg72KQL3Jmz3A9bQfyXx8VdAvhL2HUIsgtjge5bTIRUKzF XA6L00mXvPf8WMdocjRxzA==; In-Reply-To: <86wmkcwj9c.fsf@gnu.org> (message from Eli Zaretskii on Mon, 19 Aug 2024 19:49:03 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290648 Archived-At: > Cc: execvy@gmail.com, 72692@debbugs.gnu.org > Date: Mon, 19 Aug 2024 19:49:03 +0300 > From: Eli Zaretskii > > > Date: Mon, 19 Aug 2024 16:34:59 +0000 > > From: Pip Cet > > Cc: execvy@gmail.com, 72692@debbugs.gnu.org > > > > "Eli Zaretskii" writes: > > > > > Thanks, but I'd also like to see the callers which call > > > free_realized_face in a way that causes the latter to call > > > free_face_fontset. That's why I asked for backtraces from those > > > calls, but I don't think you sent such backtraces. What you sent was > > > > Just for the record, you asked: > > > > > So can you show a backtrace from the call to free_realized_faces > > > (supposedly called by realize_basic_faces?) which causes these > > > printfs: > > > > fontset 103 used for face 0x117cca0 > > > > fontset 103 used for face 0x2a7a3c0 > > > > fontset 103 used for face 0x117cca0 > > > > fontset 103 used for face 0x2a62860 > > > > ... which I misunderstood. Sorry. > > Sorry for being unclear. > > > Is this what you want? > > Yes, recompute_basic_faces was the prime suspect. I think we added > several calls to it over the last years, to fix problems with face > cache being emptied at some unexpected times. > > > Indeed, I can report that the bug doesn't seem to occur after this > > simple change: > > > > diff --git a/src/xfaces.c b/src/xfaces.c > > index 684b6ccfac7..a4ac9c0787a 100644 > > --- a/src/xfaces.c > > +++ b/src/xfaces.c > > @@ -736,6 +736,7 @@ recompute_basic_faces (struct frame *f) > > clear_face_cache (false); > > if (!realize_basic_faces (f)) > > emacs_abort (); > > + f->face_change = true; > > } > > } > > > > > > So something like that (though moving the call down into > > realize_basic_faces or even further would be good) would probably work > > for the OP, and emacs-30? > > I think setting the flag in recompute_basic_faces should be enough. > Let me think about it some more. I decided to go with this change only, and installed it on the emacs-30 release branch. Let's hope it makes this tricky problem go away. I'm closing this bug. If the problem resurfaces, we can reopen it.