From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 72765@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text
Date: Mon, 09 Sep 2024 14:46:09 +0300 [thread overview]
Message-ID: <867cblvym6.fsf@gnu.org> (raw)
In-Reply-To: <76a2f902-5876-42a3-ad06-b95d6a9959c1@gutov.dev> (message from Dmitry Gutov on Mon, 9 Sep 2024 03:20:01 +0300)
> Date: Mon, 9 Sep 2024 03:20:01 +0300
> Cc: Eli Zaretskii <eliz@gnu.org>, 72765@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> > This now aborts (segfault?). At least something different.
> >
> > So, for the record, before this patch with the latest emacs-30, I get the
> > results in failure1.txt and with your last redisplay-skip-initial-frame patch
> > I get failure2.txt.
> >
> > I've produced these files with
> >
> > make -C test eglot-tests SELECTOR=\"rust-completion\" 2>&1 | tee failure1.txt
>
> So it's reproducible. Great!
>
> Could someone look into the segfault? The repro steps are simple:
>
> 1) apply the patch above,
> 2) run 'make -C test eglot-tests' or the longer command above which
> executes just one test from that file.
>
> The backtrace that I managed to generate is attached.
Thanks. Please try the patch below.
P.S. I'm not at all sure this is the last segfault you will see
because you are playing with fire: you are not supposed to reset
redisplay-skip-initial-frame to nil in batch-mode tests that test
redisplay-related features!
diff --git a/src/xdisp.c b/src/xdisp.c
index bf7d84c..a1319e7 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -22089,7 +22089,8 @@ #define GIVE_UP(X) return 0
/* Window must either use window-based redisplay or be full width. */
if (!FRAME_WINDOW_P (f)
- && (!FRAME_LINE_INS_DEL_OK (f)
+ && (FRAME_INITIAL_P (f)
+ || !FRAME_LINE_INS_DEL_OK (f)
|| !WINDOW_FULL_WIDTH_P (w)))
GIVE_UP (4);
next prev parent reply other threads:[~2024-09-09 11:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 23:07 bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text Dmitry Gutov
2024-08-29 11:34 ` Eli Zaretskii
2024-08-30 21:23 ` Dmitry Gutov
2024-08-31 6:47 ` Eli Zaretskii
2024-08-31 12:03 ` João Távora
2024-09-01 1:43 ` Dmitry Gutov
2024-09-01 9:43 ` João Távora
2024-09-01 14:28 ` Dmitry Gutov
2024-09-03 13:20 ` Dmitry Gutov
2024-09-03 13:43 ` João Távora
2024-09-08 2:41 ` Dmitry Gutov
2024-09-08 15:51 ` João Távora
2024-09-09 0:20 ` Dmitry Gutov
2024-09-09 11:46 ` Eli Zaretskii [this message]
2024-09-10 0:58 ` Dmitry Gutov
2024-09-10 11:47 ` Eli Zaretskii
2024-09-10 13:20 ` Dmitry Gutov
2024-09-10 1:40 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cblvym6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72765@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.