From: Eli Zaretskii <eliz@gnu.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: casouri@gmail.com, luangruo@yahoo.com, stefankangas@gmail.com,
emacs-devel@gnu.org
Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324)
Date: Mon, 23 Sep 2024 14:49:12 +0300 [thread overview]
Message-ID: <867cb2h9on.fsf@gnu.org> (raw)
In-Reply-To: <87tte7mlhh.fsf@gmail.com> (message from Kévin Le Gouguec on Sun, 22 Sep 2024 23:23:06 +0200)
> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: Po Lu <luangruo@yahoo.com>, Stefan Kangas <stefankangas@gmail.com>,
> emacs-devel@gnu.org
> Date: Sun, 22 Sep 2024 23:23:06 +0200
>
> Yuan Fu <casouri@gmail.com> writes:
>
> > I took a look and it’s set for log-edit-mode only. It would be nice if magit can pick it up. I’m sure a lot of people (me included) use magit for developing Emacs. The only problem is magit’s commit message editing buffer doesn’t have a special major mode. It does git-commit-mode which is a minor mode, and runs git-commit-setup-hook. But I’m not sure how to edit dir-locals to set fill-column using a hook or minor mode.
>
> Kludge from my personal config reproduced below¹, if it can help. It
> adds a function to git-commit-setup-hook that sets fill-column when it
> detects that one of the remotes is Emacs's Savannah repo.
>
> Thinking more about it, and considering the existence of the
> git-commit-major-mode variable, I guess one could also
>
> 1) define a major mode derived from text-mode in their personal config;
> 2) add a .dir-locals-2.el file to their Emacs checkout that sets
> git-commit-major-mode to that-new-mode, and fill-column to
> *checks config*
> 63
> *checks discussion*
> ^W64
> *ponders git-blaming to see what Past Self has to say for himself*
> *looks at the time*
> *you're off the hook, Past Self*
> for that-new-mode.
Isn't it a bug in magit that it doesn't do something like that
already? Fill column is just the tip of an iceberg, because a log
message is generally human-readable text, and so should benefit from
other features of Text mode and its descendants, like spell-checking
etc.
Perhaps magit should simply use log-edit-mode?
Should we perhaps submit a feature request to the magit developers?
next prev parent reply other threads:[~2024-09-23 11:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172663360099.23732.9998257239822693024@vcs2.savannah.gnu.org>
[not found] ` <20240918042641.56C7BC410E2@vcs2.savannah.gnu.org>
2024-09-18 6:31 ` emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) Po Lu
2024-09-20 4:53 ` Yuan Fu
2024-09-20 6:32 ` Eli Zaretskii
2024-09-20 6:44 ` Eli Zaretskii
2024-09-21 3:10 ` Yuan Fu
2024-09-22 0:59 ` Stefan Kangas
2024-09-22 5:18 ` Eli Zaretskii
2024-09-22 5:43 ` Po Lu
2024-09-22 6:44 ` Yuan Fu
2024-09-22 21:23 ` Kévin Le Gouguec
2024-09-23 8:27 ` Robert Pluim
2024-09-23 11:49 ` Eli Zaretskii [this message]
2024-09-23 17:24 ` Kévin Le Gouguec
2024-09-23 18:24 ` Eli Zaretskii
2024-09-24 7:10 ` Kévin Le Gouguec
2024-09-26 7:28 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cb2h9on.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=luangruo@yahoo.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.