all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 74612@debbugs.gnu.org
Subject: bug#74612: 30.0.90; [PATCH] Allow passing nil to treesit-node-match-p
Date: Sat, 30 Nov 2024 09:22:28 +0200	[thread overview]
Message-ID: <867c8lb2yz.fsf@gnu.org> (raw)
In-Reply-To: <2D3B1979-C9A2-4843-8F64-DC26FA42EE25@gmail.com> (message from Yuan Fu on Fri, 29 Nov 2024 16:38:22 -0800)

> From: Yuan Fu <casouri@gmail.com>
> Date: Fri, 29 Nov 2024 16:38:22 -0800
> 
> Eli, are you ok with this patch on emacs-30? Almost all tree-sitter node functions allows user to pass nil for NODE, so treesit-node-match-p should too.

Does this solve an actual problem you've seen somewhere (and if so,
which problem), or does it solve a potential problem that didn't
actually happen yet?

Also, does CHECK_TS_NODE allow nil or does it currently signal an
error?





  reply	other threads:[~2024-11-30  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30  0:38 bug#74612: 30.0.90; [PATCH] Allow passing nil to treesit-node-match-p Yuan Fu
2024-11-30  7:22 ` Eli Zaretskii [this message]
2024-12-01  8:31   ` Yuan Fu
2024-12-01  9:59     ` Eli Zaretskii
2024-12-05  9:43       ` Eli Zaretskii
2024-12-06  7:24         ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867c8lb2yz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74612@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.