From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75199: 30.0.93; Emacs crashes when completing with corfu Date: Mon, 30 Dec 2024 21:17:41 +0200 Message-ID: <867c7hnfoq.fsf@gnu.org> References: <87cyh9qq64.fsf@fuzy.me> <86ttalnsj4.fsf@gnu.org> <87r05pmctv.fsf@fuzy.me> <86ldvxnqgv.fsf@gnu.org> <8ac665654425902f3deb81481ac0242c@fuzy.me> <87a5cdcape.fsf@daniel-mendler.de> <86bjwtnhyh.fsf@gnu.org> <877c7hc8q1.fsf@daniel-mendler.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: i@fuzy.me, luangruo@yahoo.com, 75199@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 30 20:18:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSLHs-0002NU-I4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Dec 2024 20:18:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSLHe-00084g-Vr; Mon, 30 Dec 2024 14:18:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSLHA-0007xo-0M for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 14:18:18 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSLH9-0001aW-Nm for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 14:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=igKNJ5WCP50y597iFE/jP17eJJRGXqC8lvaY74NpkHs=; b=rneUwiVX2Hr5fMC8/MhDAVpH8aj1rQA+QbcnJWlVIQrIT+LqzFI5UBFZTvX1bUuxEi3rTh0hEkFhKfW/f5V4BGboYMPeJ7TLVzJDzOiAhTXK2g4MrsiMWab0z50NiDdb6pv4vfRRwppeZT/ub6Ktow3iEdwFMuL1PmR9v9NGR0ogOZSZ0O95hvVdevlXUCPAenz6h9l/fJRzC60kQ8/dPSnPv9tllNtwI/d3xZPOPQJ5zuKksNG7jjWQ/2JhXmBRvs9Pd8AoPVlKwCSMZTd5F+z+qEAVwvWp6mvvIN2B6zTp8YroewWXbYDuJZAwl+cpAI2SheGhy5n9iXaBe4Yi0w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSLH8-0002Lo-KP for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 14:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2024 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75199 X-GNU-PR-Package: emacs Original-Received: via spool by 75199-submit@debbugs.gnu.org id=B75199.17355862759014 (code B ref 75199); Mon, 30 Dec 2024 19:18:02 +0000 Original-Received: (at 75199) by debbugs.gnu.org; 30 Dec 2024 19:17:55 +0000 Original-Received: from localhost ([127.0.0.1]:60016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSLH1-0002LH-5N for submit@debbugs.gnu.org; Mon, 30 Dec 2024 14:17:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSLGw-0002Kr-P0 for 75199@debbugs.gnu.org; Mon, 30 Dec 2024 14:17:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSLGo-0001Zr-Rb; Mon, 30 Dec 2024 14:17:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=igKNJ5WCP50y597iFE/jP17eJJRGXqC8lvaY74NpkHs=; b=Tjb/jFNE2hjy WW3otOYzFQzq4bgyApMR5QpkmGJEyefOOWw0q9LyGGHS+W5ETwFqsdnAPWr74NgJ2ofoEH66Lb2vG EoAhRuZzxvSzjjoR/ZMM7U0G0DEy++L6ao1S4/dqjZ6iVnwS4Bg3Zu86Xgdi8+0dkIVX9qKFLwLl/ E2iX8IvNGzEYfh0zWq5ikKHeqG3/0cg7X6MK4Hjc2wjon3fYRD0256PoI2R2ZLqpA5HNwqhYpuLne b/3ucUEdjWx4uNtiSD89OH6lhg9GsL0KdGmGIMrYRbuIxOZxmEgvrjSvuFgu41MONmelHbJoi3p/V IhhwneSblmLDsmCT/JR/1Q==; In-Reply-To: <877c7hc8q1.fsf@daniel-mendler.de> (message from Daniel Mendler on Mon, 30 Dec 2024 19:43:34 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298022 Archived-At: > From: Daniel Mendler > Cc: i@fuzy.me, luangruo@yahoo.com, 75199@debbugs.gnu.org > Date: Mon, 30 Dec 2024 19:43:34 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> Cc: Eli Zaretskii , luangruo@yahoo.com, 75199@debbugs.gnu.org > >> Date: Mon, 30 Dec 2024 19:00:45 +0100 > >> > >> Zhengyi Fu writes: > >> > >> > On 2024-12-30 23:24, Eli Zaretskii wrote: > >> > > >> >> Earlier you wrote: > >> >> > >> >>> The error is probably caused by the width value of 0 passed to > >> >>> XCreatePixmapFromBitmapData(). > >> >>> It seems gui_intersect_rectangles() returns true even if the resulted > >> >>> rectangle is empty. Is that correct behavior? > >> >> Can you tell how this happens? Is corfu doing something special with > >> >> the fringes? > >> > > >> > I noticed the following calls in corfu--popup-show before the error: > >> > > >> > * define-fringe-bitmap(corfu--bar [-241] 1 8 (top periodic)) > >> > * define-fringe-bitmap(corfu--nil []) > >> > >> I've adjusted the second call to the following, also for compatibility > >> with older Emacs versions. > >> > >> (define-fringe-bitmap 'corfu--nil [0] 1 1) > > > > Doesn't > > > > (define-fringe-bitmap 'corfu--nil [0]) > > > > work as well? If it doesn't, I guess the doc string is inaccurate? > > Yes. If I understand [info:elisp#Customizing Bitmaps] correctly, in this > case the HEIGHT would be 1, but the WIDTH would be 8. This is slightly > different from the above, but it should work just as well given that the > bitmap is all zero. The corfu--nil bitmap is just a placeholder for the > empty fringe. OK, thanks. So we can conclude that this is a bug in Corfu, and in addition install on master a check for arguments of define-fringe-bitmap, for even more waterproof fix?