From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: 75291@debbugs.gnu.org, mina86@mina86.com
Subject: bug#75291: Redisplay not updating fringe when face filter changes
Date: Fri, 03 Jan 2025 21:31:10 +0200 [thread overview]
Message-ID: <867c7bheyp.fsf@gnu.org> (raw)
In-Reply-To: <87ldvrajym.fsf@dancol.org> (message from Daniel Colascione on Fri, 03 Jan 2025 12:25:05 -0500)
> From: Daniel Colascione <dancol@dancol.org>
> Cc: 75291@debbugs.gnu.org, mina86@mina86.com
> Date: Fri, 03 Jan 2025 12:25:05 -0500
>
> > I think it depends on whether you use double-buffering (some people
> > don't or cannot) and whether you have the mouse pointer over an Emacs
> > frame. Also, depending on the GUI toolkit, the decorations might
> > flicker.
>
> TTY windows don't have fringes, and the most commonly-used window
> systems all do atomic updates nowadays.
People still report flickering from time to time, so I don't think
this never happens.
> > So you want to add to display_line code that sets each glyph_row's
> > redraw_fringe_bitmaps_p flag when the fringe face changes? That could
> > probably work, provided that we disable redisplay optimizations which
> > might avoid calling display_line (you will see that we already disable
> > such optimizations when overlay_arrows_changed_p returns non-zero).
> > We might actually need to disable more of the optimizations, because
> > the overlay-arrow thing doesn't contradict the optimizations that
> > scroll the pixels, something that reaction to changes in the fringe
> > face cannot tolerate.
>
> That might work, but I don't think we even need anything that
> complicated or low-level. Not many are using :filtered now, and those
> that do big redraws anyway. How about this simpler code that gets us
> correctness, albeit more conservatively?
Doesn't that only support face remapping with :filtered attribute?
What about the more general case where the fringe face is remapped in
a way that's independent of the windows?
next prev parent reply other threads:[~2025-01-03 19:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 17:30 bug#75291: Redisplay not updating fringe when face filter changes Daniel Colascione
2025-01-02 17:50 ` Eli Zaretskii
2025-01-02 18:36 ` Daniel Colascione
2025-01-02 19:24 ` Michal Nazarewicz
2025-01-02 19:26 ` Eli Zaretskii
2025-01-02 19:50 ` Daniel Colascione
2025-01-02 20:56 ` Eli Zaretskii
2025-01-03 17:25 ` Daniel Colascione
2025-01-03 19:31 ` Eli Zaretskii [this message]
2025-01-03 19:46 ` Daniel Colascione
2025-01-03 20:10 ` Eli Zaretskii
2025-01-03 20:27 ` Eli Zaretskii
2025-01-03 20:57 ` Daniel Colascione
2025-01-04 7:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867c7bheyp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=75291@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.