From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in Date: Wed, 10 Apr 2019 11:53:42 -0700 Message-ID: <86697de6baf024290a9d0b10743ba2b7.squirrel@dancol.org> References: <20190409224339.20116.87667@vcs0.savannah.gnu.org> <20190409224342.0DA1F20E54@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="167993"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.23 [SVN] To: emacs-devel@gnu.org, "Paul Eggert" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 10 20:53:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEIM7-000hZr-4Y for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 20:53:56 +0200 Original-Received: from localhost ([127.0.0.1]:35952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEIM6-00071U-5d for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 14:53:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEILy-00071K-EH for emacs-devel@gnu.org; Wed, 10 Apr 2019 14:53:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEILx-0001ar-Cn for emacs-devel@gnu.org; Wed, 10 Apr 2019 14:53:46 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:37528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEILw-0001VY-On for emacs-devel@gnu.org; Wed, 10 Apr 2019 14:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=ANG4Zem4Khz3qg+LLwhLMsWfLX5coPX7rTBOVb6A4/E=; b=ZUi+DBuGWeaVlvsWppR9vJOh9w0Yd47QoH7nVWUGln7iPIG7NK1u8CF8zndY8iCr966Lc9MrOBOXT6TQkAMFjJYwiNmYonb5DpgTLhXiym8GdRSIXWt1tctEWirGUXAPsFQWUf3Qlp+Af4amo1M15ZEXAuwg/vXNRuPjk6UC+zIUSz7zipTOdkQb0Br2QN65NYkiXZB8OhgzHN4UGvECGQ0lqEFVS/EQnCh0dNKdJT1lJToACzWljFsSfrHlGuN+xq/xfsjGh45sbjOtAdlvpssPaD2E3d+xbyj/cMf/qVUl3h07mFqH7f9/oD+M9Df/kd2lKHR1g7hjy+1ZwDWW5w==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEILu-0005oR-OF; Wed, 10 Apr 2019 11:53:42 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 10 Apr 2019 11:53:42 -0700 In-Reply-To: <20190409224342.0DA1F20E54@vcs0.savannah.gnu.org> X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235239 Archived-At: > branch: master > commit d82603747564063f908c9c877449c827a9808528 > Author: Paul Eggert > Commit: Paul Eggert > > Remove the need for temacs.in > > Instead of building a file temacs.in used only to compute a > fingerprint, compute the fingerprint directly from the .o and > .a files that go into temacs.in. This speeds up the build by > avoiding the need to link temacs twice, once with a dummy > fingerprint. Please don't do this. Computing a fingerprint over temacs.in factors link layout information into the fingerprint hash. Your approach doesn't. It's possible to link Emacs in different ways from the same object files and produce different binaries. I don't think a little build speedup is worth the safety loss.