From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#20734: 25.0.50; "Args out of range" with help-window-select t Date: Fri, 05 Jun 2015 21:48:40 +0200 Message-ID: <866172rl5z.fsf@members.fsf.org> References: <86vbf3tfwj.fsf@members.fsf.org> <83r3pqpsh0.fsf@gnu.org> <867fritskw.fsf@members.fsf.org> <83bngup8ub.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1433533836 15886 80.91.229.3 (5 Jun 2015 19:50:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Jun 2015 19:50:36 +0000 (UTC) Cc: 20734@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 05 21:50:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z0xd7-0002hh-6d for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 21:50:13 +0200 Original-Received: from localhost ([::1]:49328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0xd6-0000oa-Q3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 15:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0xd3-0000o4-3q for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:50:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0xcy-000447-4N for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:50:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0xcy-00043f-0f for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z0xcx-0005Rv-EN for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 15:50:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 19:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20734-submit@debbugs.gnu.org id=B20734.143353375220884 (code B ref 20734); Fri, 05 Jun 2015 19:50:03 +0000 Original-Received: (at 20734) by debbugs.gnu.org; 5 Jun 2015 19:49:12 +0000 Original-Received: from localhost ([127.0.0.1]:42114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0xc8-0005Ql-83 for submit@debbugs.gnu.org; Fri, 05 Jun 2015 15:49:12 -0400 Original-Received: from mailrelay117.isp.belgacom.be ([195.238.20.144]:46072) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0xc5-0005QU-2r for 20734@debbugs.gnu.org; Fri, 05 Jun 2015 15:49:09 -0400 X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=i+EX5EtM4g4P/CrLY+sx2nOWHsqv9AlVwqc0uudqMuE= c=1 sm=2 a=a4K5GIyuExAA:10 a=IkcTkHD0fZMA:10 a=mDV3o1hIAAAA:8 a=2ezBBItVNe95PRnNio0A:9 a=QEXdDO2ut3YA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BoEQDM/HFV/7KQsltbgxCBMoMeqUUFAYEEkQWHUgKBNTsSAQEBAQEBAYEKQQODXwEBAwEjBC8jBQsIAxoCBSECAg8BBCUkE4glDAG3faQGAQEBBwIBH4EhhHiFKoRTMweCaIFFAQSGba8uJIN5PDGBAySBIAEBAQ Original-Received: from 178.144-178-91.adsl-dyn.isp.belgacom.be (HELO Aurora) ([91.178.144.178]) by relay.skynet.be with ESMTP; 05 Jun 2015 21:48:42 +0200 In-Reply-To: <83bngup8ub.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jun 2015 16:45:32 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103626 Archived-At: Eli Zaretskii writes: > Yes, that's the bug. But the real problem is that we've switched > windows temporarily, and we shouldn't move point in the current buffer > at all when we do that. Ok. I think I understand now. What about adding an assertion to make sure current_buffer is shown in selected_window at that point? > I think we shouldn't call adjust_point_for_property in this case > at all. Can you see if adding > > && EQ (XWINDOW (selected_window)->contents, current_buffer) > > to the condition that guards the call to adjust_point_for_property > fixes the problem? Yes it does, but I wrapped the lhs into XBUFFER : && EQ (XBUFFER (XWINDOW (selected_window)->contents), current_buffer) otherwise it complains: --8<---------------cut here---------------start------------->8--- In file included from keyboard.c:26:0: keyboard.c: In function =E2=80=98command_loop_1=E2=80=99: lisp.h:339:34: warning: comparison between pointer and integer [enabled by = default] #define lisp_h_EQ(x, y) (XLI (x) =3D=3D XLI (y)) ^ lisp.h:388:19: note: in expansion of macro =E2=80=98lisp_h_EQ=E2=80=99 # define EQ(x, y) lisp_h_EQ (x, y) ^ keyboard.c:1621:7: note: in expansion of macro =E2=80=98EQ=E2=80=99 && EQ (XWINDOW (selected_window)->contents, current_buffer) ^ --8<---------------cut here---------------end--------------->8--- --=20 Nico.