From: Nicolas Richard <youngfrog@members.fsf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20734@debbugs.gnu.org
Subject: bug#20734: 25.0.50; "Args out of range" with help-window-select t
Date: Fri, 05 Jun 2015 21:48:40 +0200 [thread overview]
Message-ID: <866172rl5z.fsf@members.fsf.org> (raw)
In-Reply-To: <83bngup8ub.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jun 2015 16:45:32 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Yes, that's the bug. But the real problem is that we've switched
> windows temporarily, and we shouldn't move point in the current buffer
> at all when we do that.
Ok. I think I understand now. What about adding an assertion to make
sure current_buffer is shown in selected_window at that point?
> I think we shouldn't call adjust_point_for_property in this case
> at all. Can you see if adding
>
> && EQ (XWINDOW (selected_window)->contents, current_buffer)
>
> to the condition that guards the call to adjust_point_for_property
> fixes the problem?
Yes it does, but I wrapped the lhs into XBUFFER :
&& EQ (XBUFFER (XWINDOW (selected_window)->contents), current_buffer)
otherwise it complains:
--8<---------------cut here---------------start------------->8---
In file included from keyboard.c:26:0:
keyboard.c: In function ‘command_loop_1’:
lisp.h:339:34: warning: comparison between pointer and integer [enabled by default]
#define lisp_h_EQ(x, y) (XLI (x) == XLI (y))
^
lisp.h:388:19: note: in expansion of macro ‘lisp_h_EQ’
# define EQ(x, y) lisp_h_EQ (x, y)
^
keyboard.c:1621:7: note: in expansion of macro ‘EQ’
&& EQ (XWINDOW (selected_window)->contents, current_buffer)
^
--8<---------------cut here---------------end--------------->8---
--
Nico.
next prev parent reply other threads:[~2015-06-05 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 19:47 bug#20734: 25.0.50; "Args out of range" with help-window-select t Nicolas Richard
2015-06-04 22:27 ` Stefan Monnier
2015-06-05 9:33 ` Nicolas Richard
2015-06-05 13:46 ` Eli Zaretskii
2015-06-05 6:41 ` Eli Zaretskii
2015-06-05 9:25 ` Nicolas Richard
2015-06-05 13:45 ` Eli Zaretskii
2015-06-05 19:48 ` Nicolas Richard [this message]
2015-06-05 19:56 ` Eli Zaretskii
2015-06-06 8:44 ` Nicolas Richard
2015-06-06 8:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=866172rl5z.fsf@members.fsf.org \
--to=youngfrog@members.fsf.org \
--cc=20734@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.