From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#20734: 25.0.50; "Args out of range" with help-window-select t Date: Sat, 06 Jun 2015 10:44:26 +0200 Message-ID: <866171kyz9.fsf@members.fsf.org> References: <86vbf3tfwj.fsf@members.fsf.org> <83r3pqpsh0.fsf@gnu.org> <867fritskw.fsf@members.fsf.org> <83bngup8ub.fsf@gnu.org> <866172rl5z.fsf@members.fsf.org> <83pp5and3z.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1433580332 27000 80.91.229.3 (6 Jun 2015 08:45:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Jun 2015 08:45:32 +0000 (UTC) Cc: 20734-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 06 10:45:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z19j6-0008B6-Uy for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jun 2015 10:45:13 +0200 Original-Received: from localhost ([::1]:51041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z19j6-0003hf-3R for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jun 2015 04:45:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z19j2-0003gX-Rb for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 04:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z19iy-0007kh-LF for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 04:45:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z19iy-0007kJ-Ia for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 04:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z19iy-0006TS-4S for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 04:45:04 -0400 In-Reply-To: <86vbf3tfwj.fsf@members.fsf.org> Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2015 08:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 20734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 20734@debbugs.gnu.org, youngfrog@members.fsf.org, youngfrog@members.fsf.org Original-Received: via spool by 20734-done@debbugs.gnu.org id=D20734.143358027724833 (code D ref 20734); Sat, 06 Jun 2015 08:45:02 +0000 Original-Received: (at 20734-done) by debbugs.gnu.org; 6 Jun 2015 08:44:37 +0000 Original-Received: from localhost ([127.0.0.1]:42537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z19iW-0006ST-Fa for submit@debbugs.gnu.org; Sat, 06 Jun 2015 04:44:37 -0400 Original-Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:38058) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z19iT-0006SC-Rc for 20734-done@debbugs.gnu.org; Sat, 06 Jun 2015 04:44:34 -0400 X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=Q1Q/C1EQSVRz+P2kPc4NLwp2Y210MHxbkbuPGccmY1k= c=1 sm=2 a=a4K5GIyuExAA:10 a=nmk0J00Q2oT7sOBZjwYA:9 a=aBChNl1bNp0A:10 a=e11NVG2hIEkA:10 a=inoG4m36AAAA:8 a=gVAV3d_zucKrCcLm70kA:9 a=L5RQGbJKxCZruY3lWrAA:9 a=uNfrmFbzc7gA:10 a=BJZSS4nxfoIA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DoFwDvsXJV/7KQsltbgxCBMqxfAQEBAQEBBQEFf5hegS1NAQEBAQEBgQtBA4NeAQEBAwEnLyMFCwgDEQMBAgolDwEEJRYIBhMbiAoMAdsQAQEBAQYCAR+GGYUqhHURhDQBBJ91kk2DWSSDeTwxgkcBAQE Original-Received: from 178.144-178-91.adsl-dyn.isp.belgacom.be (HELO Aurora) ([91.178.144.178]) by relay.skynet.be with ESMTP; 06 Jun 2015 10:44:27 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103647 Archived-At: --=-=-= Content-Type: text/plain >> Ok. I think I understand now. What about adding an assertion to make >> sure current_buffer is shown in selected_window at that point? > > That'd be fine with me. I can suggest : --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-assertion-in-adjust_point_for_property.patch >From 52cd3204743442fc6d8fc281ed3d9b0b0e6a88e4 Mon Sep 17 00:00:00 2001 From: Nicolas Richard Date: Sat, 6 Jun 2015 10:05:07 +0200 Subject: [PATCH] Add assertion in adjust_point_for_property * src/keyboard.c (adjust_point_for_property): Add eassert for current buffer being shown in selected window. --- src/keyboard.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/keyboard.c b/src/keyboard.c index bedd10b..23f7ce7 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -1687,6 +1687,8 @@ adjust_point_for_property (ptrdiff_t last_pt, bool modified) bool check_composition = ! modified, check_display = 1, check_invisible = 1; ptrdiff_t orig_pt = PT; + eassert (XBUFFER (XWINDOW (selected_window)->contents) == current_buffer); + /* FIXME: cycling is probably not necessary because these properties can't be usefully combined anyway. */ while (check_composition || check_display || check_invisible) -- 1.9.1 --=-=-= Content-Type: text/plain >> && EQ (XBUFFER (XWINDOW (selected_window)->contents), current_buffer) > in that case, you don't need EQ, just use == to > compare 2 C pointers. Ok, I pushed that solution as d31cd49 and I mark the bug as done. Thanks for your guidance. -- Nico. --=-=-=--