From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0 Date: Sat, 11 Aug 2018 19:36:34 +0100 Message-ID: <86600giwct.fsf@gmail.com> References: <86a7q0ai2z.fsf@gmail.com> <6d36dc4c-1e14-b6c8-e2f0-911d08f759e1@cs.ucla.edu> <83in4os01j.fsf@gnu.org> <16f2754a-b40e-4bc4-f95a-9bada460d5a4@cs.ucla.edu> <83bma9mh3z.fsf@gnu.org> <86eff52njj.fsf@gmail.com> <83wosxkwfz.fsf@gnu.org> <864lg1rlp0.fsf@gmail.com> <83mutslt8f.fsf@gnu.org> <86in4gixg3.fsf@gmail.com> <83d0uolpxt.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534012529 2201 195.159.176.226 (11 Aug 2018 18:35:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Aug 2018 18:35:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 11 20:35:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foYjR-0000RO-4y for ged-emacs-devel@m.gmane.org; Sat, 11 Aug 2018 20:35:21 +0200 Original-Received: from localhost ([::1]:32865 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foYlX-0005zA-IB for ged-emacs-devel@m.gmane.org; Sat, 11 Aug 2018 14:37:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foYkq-0005z3-Tf for emacs-devel@gnu.org; Sat, 11 Aug 2018 14:36:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foYkm-00049y-Pm for emacs-devel@gnu.org; Sat, 11 Aug 2018 14:36:48 -0400 Original-Received: from [195.159.176.226] (port=55042 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foYkm-00049L-IP for emacs-devel@gnu.org; Sat, 11 Aug 2018 14:36:44 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1foYib-00085B-Sk for emacs-devel@gnu.org; Sat, 11 Aug 2018 20:34:29 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:aS62Z2NvwM5WGzTmibLmycGp2vY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228423 Archived-At: On Sat 11 Aug 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Sat, 11 Aug 2018 19:13:00 +0100 >> >> > Does it help to take the GetProcAddress call in parentheses, like >> > this: >> > >> > s_pfn_Get_Module_HandleExA = >> > (GetModuleHandleExA_Proc) (GetProcAddress (hm_kernel32, >> > "GetModuleHandleExA")); >> >> Doesn't help - gcc still warns. >> >> > If this doesn't help, what about removing the cast entirely? >> >> Also still warns. This does work: >> >> s_pfn_Get_Module_HandleExA = >> (GetModuleHandleExA_Proc) (void (*)(void)) >> GetProcAddress (hm_kernel32, "GetModuleHandleExA"); >> >> This is sliughtly less ugly and also pacifies the warning: >> >> #define FN_PTR_CAST(fnptrtype, fnptr) \ >> ((fnptrtype) (void (*)(void)) (fnptr)) >> >> s_pfn_Get_Module_HandleExA = >> FN_PTR_CAST(GetModuleHandleExA_Proc, >> GetProcAddress (hm_kernel32, "GetModuleHandleExA")); > > I'd rather disable the warning around the code which uses these casts. > Or maybe we should introduce our ownj get_proc_address, which returns > a (void (*)(void)) pointer. But that's not for emacs-26, sorry. Given how many source files are involved, for emacs-26 the simplest thing is simply to disable -Wcast-function-type in configure.ac. For master we can leave the warning enabled if the GetProcAddress calls can be fixed to pacify the warning. AndyM