From: Andy Moreton <andrewjmoreton@gmail.com>
To: 35507@debbugs.gnu.org
Subject: bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird
Date: Wed, 01 May 2019 01:35:09 +0100 [thread overview]
Message-ID: <865zqv3tc2.fsf@gmail.com> (raw)
In-Reply-To: <44a26585-7980-378c-9262-a567ddd3e617@cs.ucla.edu>
On Tue 30 Apr 2019, Paul Eggert wrote:
> The attachment has a text/* media type but it has no charset parameter.
> The patch itself (output by git format-patch) says its charset is UTF-8.
> Unfortunately, Gnus doesn't recognize the patch as UTF-8 and so
> mishandles the non-ASCII characters in the attachment. To reproduce the
> problem, read this email with Gnus; the full attachment is attached to
> this email in the Thunderbird way.
>
> Although Internet RFC 2046 section 4.1.2 says the default charset for
> text/* media types is US-ASCII, Internet RFC 6557 section 3 amends this
> to say that registered text/* media types should require a charset
> specification (or should say it's not needed because the payload has
> that info, which obviously doesn't apply here). It later says that if
> there is a strong reason to have a charset default, the default should
> be UTF-8.
>
> Unfortunately Gnus apparently doesn't default to UTF-8 for such
> attachments, which means that sending a text/x-patch attachment from
> Thunderbird to Gnus messes up if the attachment contains non-ASCII
> characters. This has been causing problems on the Emacs mailing list for
> years and it bit a correspondent of mine again today; see
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35502#35>.
>
> I have filed a Thunderbird bug report for this, as Thunderbird should
> specify a charset; see
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1167982>. However, Gnus
> should be a polite citizen and handle these attachments nicely rather
> than converting the non-ASCII UTF-8 characters to mojibake.
After a bit of experimenting, this minimal patch appears to fix things.
Should this also allow the user to choose the charset if none is
specified, or just hardwire it to utf-8 ?
diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
index 3f255419e7..a99d52a7e7 100644
--- a/lisp/gnus/mm-decode.el
+++ b/lisp/gnus/mm-decode.el
@@ -665,6 +665,9 @@ mm-dissect-buffer
(setq type (split-string (car ctl) "/"))
(setq subtype (cadr type)
type (car type))
+ ;; Fix missing charset in Thunderbird
+ (unless (assq 'charset (cdr ctl))
+ (push '(charset . utf-8) (cdr ctl)))
(setq
result
(cond
next prev parent reply other threads:[~2019-05-01 0:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 19:20 bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird Paul Eggert
2019-05-01 0:35 ` Andy Moreton [this message]
2019-05-01 15:22 ` Robert Pluim
2019-05-01 15:45 ` Andy Moreton
2019-05-01 16:42 ` Andy Moreton
2019-05-01 17:36 ` Eli Zaretskii
2019-05-01 23:54 ` Andy Moreton
2019-05-02 3:07 ` Noam Postavsky
2019-05-02 7:17 ` Andy Moreton
2019-05-02 11:04 ` Eli Zaretskii
2019-05-02 15:43 ` Andy Moreton
2019-05-02 15:57 ` Eli Zaretskii
2019-05-02 16:08 ` Andy Moreton
2019-05-02 16:50 ` Eli Zaretskii
2019-05-02 17:13 ` Eric Abrahamsen
2019-05-02 17:45 ` Andy Moreton
2019-05-02 16:10 ` Basil L. Contovounesios
2019-05-02 16:50 ` Eli Zaretskii
2019-05-02 17:20 ` Eli Zaretskii
2019-05-03 13:55 ` Basil L. Contovounesios
2019-05-02 16:29 ` Robert Pluim
2019-05-02 16:53 ` Eli Zaretskii
2019-05-02 12:01 ` Noam Postavsky
2019-05-02 15:40 ` Eli Zaretskii
2019-05-03 14:02 ` Basil L. Contovounesios
2019-05-03 15:14 ` Eli Zaretskii
2019-05-03 15:20 ` Basil L. Contovounesios
2019-05-01 17:34 ` Eli Zaretskii
2019-05-02 6:35 ` Robert Pluim
2019-05-01 17:33 ` Eli Zaretskii
2019-05-01 17:32 ` Eli Zaretskii
2019-05-01 18:26 ` Paul Eggert
2019-05-01 19:05 ` Eli Zaretskii
2019-05-01 19:47 ` Andreas Schwab
2019-05-01 19:57 ` Eli Zaretskii
2019-05-02 23:24 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865zqv3tc2.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=35507@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.