From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Thu, 17 Mar 2022 22:56:01 +0200 Organization: LINKOV.NET Message-ID: <865yoc47d2.fsf@mail.linkov.net> References: <874k454n84.fsf@gnus.org> <86ilslmvql.fsf@mail.linkov.net> <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86ee357wob.fsf@mail.linkov.net> <20220314090826.gyc42227jpvh4efa@Ergus> <86zglsiazs.fsf@mail.linkov.net> <20220317184701.ani7k3clp3impqwn@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24576"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 17 22:16:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUxTq-0006CL-FC for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Mar 2022 22:16:22 +0100 Original-Received: from localhost ([::1]:56094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUxTp-00028b-8J for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Mar 2022 17:16:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUxSz-0001Lb-5B for emacs-devel@gnu.org; Thu, 17 Mar 2022 17:15:29 -0400 Original-Received: from [2001:4b98:dc4:8::224] (port=51365 helo=relay4-d.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUxSx-000788-48 for emacs-devel@gnu.org; Thu, 17 Mar 2022 17:15:28 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 04779E0006; Thu, 17 Mar 2022 21:15:21 +0000 (UTC) In-Reply-To: <20220317184701.ani7k3clp3impqwn@Ergus> (Ergus's message of "Thu, 17 Mar 2022 19:47:01 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::224 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287259 Archived-At: >> But cursor-face is not highlighted in *Completions* when the current buffer >> is the minibuffer. Such highlighting is necessary when completions >> are navigated from the minibuffer. > Please check the change and try to set > cursor-face-highlight-nonselected-window unconditionally in > *Completions* to t when using your mode. Now it keeps highlighting in *Completions* after switching to the minibuffer, but still doesn't move the highlighting in *Completions* when completions are navigated from the minibuffer with (defmacro with-minibuffer-completions-window (&rest body) "Execute the forms in BODY from the minibuffer in its completions window. When used in a minibuffer window, select the window with completions, and execute the forms." (declare (indent 0) (debug t)) `(let ((window (or (get-buffer-window "*Completions*" 0) ;; Make sure we have a completions window. (progn (minibuffer-completion-help) (get-buffer-window "*Completions*" 0))))) (when window (with-selected-window window ,@body)))) (defun minibuffer-next-completion (&optional n) "Run `next-completion' from the minibuffer in its completions window." (interactive "p") (with-minibuffer-completions-window (next-completion n))) > If you could improve the initialization in order to use > cursor-in-non-selected-windows unless the user sets another value > manually it may be nicer (because in the general scenario the user could > set cursor-in-non-selected-windows latter so this variable may have an > outdated value) otherwise consider if this may be simply t or nil by > default. But at the moment it works fine for the current use cases. I think it's unrelated to cursor-in-non-selected-windows because the cursor in non-selected windows is displayed as a hollow box, but cursor-face stays the same. So you can set cursor-face-highlight-nonselected-window to nil by default. Then commands could let-bind it like (defun minibuffer-next-completion (&optional n) "Run `next-completion' from the minibuffer in its completions window." (interactive "p") (let ((cursor-face-highlight-nonselected-window t)) (with-minibuffer-completions-window (next-completion n)))) (but this currently doesn't work for the same reason as above)