From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62250: 29.0.60; Allow context menu from text properties to not override everything Date: Sat, 18 Mar 2023 20:08:34 +0200 Organization: LINKOV.NET Message-ID: <865yaxq5xh.fsf@mail.linkov.net> References: <87ttyixzt2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4799"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62250@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 19:30:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdbJv-00019r-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 19:30:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdbJh-00076J-F9; Sat, 18 Mar 2023 14:30:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdbJa-00075y-JG for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 14:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdbJa-0006zF-9Y for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 14:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdbJZ-0003Xy-WF for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 18:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62250 X-GNU-PR-Package: emacs Original-Received: via spool by 62250-submit@debbugs.gnu.org id=B62250.167916414213531 (code B ref 62250); Sat, 18 Mar 2023 18:30:01 +0000 Original-Received: (at 62250) by debbugs.gnu.org; 18 Mar 2023 18:29:02 +0000 Original-Received: from localhost ([127.0.0.1]:49046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbIb-0003WB-Vl for submit@debbugs.gnu.org; Sat, 18 Mar 2023 14:29:02 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:39049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbIZ-0003Va-OT for 62250@debbugs.gnu.org; Sat, 18 Mar 2023 14:29:00 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 544D124000C; Sat, 18 Mar 2023 18:28:51 +0000 (UTC) In-Reply-To: <87ttyixzt2.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Mar 2023 08:51:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258202 Archived-At: > It would be nice if the context menu defined by a text property had the > option of adding to instead of overriding the menu specified by > `context-menu-functions'. > > I think this can be done in a backwards-compatible way as follows: > > (defun context-menu-map (&optional click) > ... > When there is a text property `context-menu-function' at CLICK, it is > handled as if it were the first entry of `context-menu-functions'. I already envisioned such request, so the text property is named `context-menu-function' (singular). As an improvement we could add another text property `context-menu-functions' (plural) that will play more nicely with the variable `context-menu-functions'. For example, we could append the list from the text property to the value of the variable before running `run-hook-wrapped' on the composite list.