From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Thu, 01 Feb 2024 11:52:19 +0200 Message-ID: <865xz81pgs.fsf@gnu.org> References: <83zfx39mcy.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11811"; mail-complaints-to="usenet@ciao.gmane.io" Cc: liuhui1610@gmail.com, 68559@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 01 10:53:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVTkt-0002os-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Feb 2024 10:53:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVTkl-0000gO-FZ; Thu, 01 Feb 2024 04:53:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVTkb-0000fh-1Y for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 04:52:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVTka-0005Di-DQ for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 04:52:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVTkk-00053T-D7 for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 04:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2024 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170678116119406 (code B ref 68559); Thu, 01 Feb 2024 09:53:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 1 Feb 2024 09:52:41 +0000 Original-Received: from localhost ([127.0.0.1]:40245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVTkP-00052u-FJ for submit@debbugs.gnu.org; Thu, 01 Feb 2024 04:52:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVTkO-00052j-Cs for 68559@debbugs.gnu.org; Thu, 01 Feb 2024 04:52:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVTk8-00059s-Bb; Thu, 01 Feb 2024 04:52:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TWg0LufrM05is+QL3gzY8P8w/Is5HlzfyyCQKLbdzig=; b=hdEBVUk2oFL2 3aAnZYHnbr1vsQBNrslb4t9xO9pweQvJWTjkV+1R+bu+Iz3OoMEm6KAUvST+7lPP5+E10Vjs1KT/N 8qONbUyRodpwkmgO4xrzJesbCVdvXTsbIr/BGNL1wnyRbAVy9RS3ZuIX6MbywGn2Zk9jTRT0jsWYE uESwAFSoNpw/1HJxoIiT+2Ym7kD6x3sdV6Q8i/CYLMdvLttWNmVShjtXhYynXcOLjP4Se+JQYoMpG +GtYKmTeBHEnwvHCjDNpMgkIVQclkQlW6K8h4l0S97s+qQy188bvbP3Sjztxyud7HSKDK7l5DWRI2 nyvFU6TPR9bthxYSiW4fOA==; In-Reply-To: (message from kobarity on Mon, 29 Jan 2024 22:15:20 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279272 Archived-At: > Date: Mon, 29 Jan 2024 22:15:20 +0900 > From: kobarity > Cc: Eli Zaretskii , > 68559@debbugs.gnu.org > > kobarity wrote: > > Liu Hui wrote: > > > Thanks for pointing it out. The attached patch should now restore > > > previous basic completion behavior in comments. > > > > Thanks, I confirmed that basic completion (without keyword argument > > completion) can be performed within comments. > > One additional comment regarding ERT. pyenv installs an ipython shim > to the shims directory, if there is at least one virtualenv providing > ipython. It can be found by `executable-find'. However, it is not > usable unless the virtualenv is activated. As a result, the > `python-shell-completion-at-point-ipython' ERT would fail unless a > virtualenv which provides ipython is activated. > > This may be something pyenv users should take care of, but it is more > convenient for pyenv users like me to make the following changes. Do we have a consensus about this issue? Should I install the original patch, or are you still discussing it, and an updated patch will be posted soon? Thanks.