From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Fri, 19 Apr 2024 09:45:15 +0300 Message-ID: <865xwddf5w.fsf@gnu.org> References: <4e670617-6483-4159-a5cf-27a921764c38@email.android.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33594"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70036@debbugs.gnu.org, felician.nemeth@gmail.com, joaotavora@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 19 08:47:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxi1e-0008Wj-Ib for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Apr 2024 08:47:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxi1P-0003vU-1m; Fri, 19 Apr 2024 02:46:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxi1L-0003pJ-5d for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 02:46:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxi1K-000212-Lc for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 02:46:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxi1Y-00024T-7l for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 02:47:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2024 06:47:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.17135091703864 (code B ref 70036); Fri, 19 Apr 2024 06:47:04 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 19 Apr 2024 06:46:10 +0000 Original-Received: from localhost ([127.0.0.1]:57119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxi0e-0000zG-K8 for submit@debbugs.gnu.org; Fri, 19 Apr 2024 02:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxi0a-0000ry-QA for 70036@debbugs.gnu.org; Fri, 19 Apr 2024 02:46:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxi0G-0001vV-AE; Fri, 19 Apr 2024 02:45:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uBl6jSLWhqIaySs/8FhnCM7kd/I5F2XNiuvI9X4mTeY=; b=aXq26zJIUm9ArFQoI7wJ tTbm3nQSowLpLz0KyyiL+bbeE0XtltBf15+HdlLhstsDz3DE1v9/z59BOog2oU2Ek1B3Z5Q4xT1vk mDEYBQk1gtFVMxW1Rxufz/FOh1frNtiASNNkbO3j/xD0RlHSlKdquCQqZaJbkSFLujCixSeXRWbSA x/EooBrsPuF/GCGVsgOnFy18RH5JMjGV9tYxudjCUXfFYvW+iWNwsdC4T4DNxh6UWRxxl0TR5MzK4 WG+U06x93oTX4GJN+zSHdLPYcNxkpdQDBsbznm6g14j5TsDOY0aBSO51r3cN44CLNBZswJpofhACs 51Lfi1X2w9ChcA==; In-Reply-To: <4e670617-6483-4159-a5cf-27a921764c38@email.android.com> (message from Theodor Thornhill on Thu, 18 Apr 2024 23:32:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283636 Archived-At: > Date: Thu, 18 Apr 2024 23:32:00 +0200 > From: Theodor Thornhill > Cc: Eli Zaretskii , felician.nemeth@gmail.com, > 70036@debbugs.gnu.org > > I'll add two profiles, one is profile-fast and profile-slow. You can > guess which is which :) > > STEPS: > I've made an intentionally broken commit into a golang repo I just > forked, to get some publishDiagnostics quickly. > > (for good measure evaluate eglot.el before running profiles) > > 1. Install gopls > 2. Make some directory you can wipe out after the test and cd into it > 3. git clone git@github.com:theothornhill/gin.git foo/bar/baz/foo/bar/baz/foo/bar/baz/foo/bar/baz/gin > 4. cd foo/bar/baz/foo/bar/baz/foo/bar/baz/foo/bar/baz/gin > 5. open fs.go in emacs and make sure some go mode is available. Go-ts-mode for example > 6. M-x profiler-start > 7. M-x eglot > 8. Wait 10-20 seconds. Do no actions other than let the lsp settle. > 9. M-x profiler-stop > 10. M-x profiler-report > 11. Rinse repeat with both or all variants of emacs with/without the > latest eglot changes. > I'll add my profiles, and let some metrics talk. Thanks, but that is not what I asked to provide, for us to make a decision in this case. I asked to provide results of a benchmark-run or similar measure of the run time. Profiles, by contrast, are much harder to interpret when the issue is the overall time it takes to perform some operations. Could you please show benchmark times of the old code (before your changes), the code after your changes, and the current code in Git (after João reverted your change and installed his own improvements)? This will allow us to see the times (both processing and GC) of each variant, and will allow to compare their performance. Thanks.