From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default Date: Wed, 01 May 2024 15:15:03 +0300 Message-ID: <865xvxpw3c.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="890"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70691@debbugs.gnu.org To: Lin Sun , Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 01 14:16:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s28sX-000AaZ-9b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 May 2024 14:16:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s28sN-0001A1-3B; Wed, 01 May 2024 08:15:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s28s9-00018o-9T for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 08:15:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s28s9-0005ui-0i for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 08:15:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s28sT-00061M-Vb for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 08:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2024 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70691-submit@debbugs.gnu.org id=B70691.171456573619857 (code B ref 70691); Wed, 01 May 2024 12:16:01 +0000 Original-Received: (at 70691) by debbugs.gnu.org; 1 May 2024 12:15:36 +0000 Original-Received: from localhost ([127.0.0.1]:37177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s28s4-00059H-Bw for submit@debbugs.gnu.org; Wed, 01 May 2024 08:15:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s28s3-0004pU-6O for 70691@debbugs.gnu.org; Wed, 01 May 2024 08:15:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s28rb-0005rx-Bw; Wed, 01 May 2024 08:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j6aMuQ7KUU5FhwkvVyKAe6+3ur9rP1S71F1F9dGIvgM=; b=Udn9yAq/Fleq 63kqsLsZQ6sa7s8LQWEm5fQQVM6gC7sPA448ZLeBKbi6pmHbVOcQnR4e9WUTtu0MXR1PuIzC8qgTs Mb6kXL+H5lFBvr0NPLMlS4hQWCPEDjRIOcr0CFQBnL/D/ZPjeAYBtb1lU5xlIJoB+IMH4+KiNWWaw GznIC6k9vKgju4iDFIeyynZ7Od9C8mkOI+me/OqUkeSDvkh9dQMJcyJpnQuJ/0DZM3tm6tZjTRq49 4U8mUV0juGSAloqC3CkEC2nTjKAsohb0Q0sjmgh360L1W5dGaJgPb3+0OsipeIp4bsXrRApI7P8H6 33okFjg9M0M0lIFWvEmdTA==; In-Reply-To: (message from Lin Sun on Wed, 1 May 2024 06:40:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284250 Archived-At: > From: Lin Sun > Date: Wed, 1 May 2024 06:40:25 +0000 > > Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. > And the function `eshell-exec-visual` can support the executables with > colors, eg VIM, tmux... > I have tested the "/bin/ls --color=tty", "/bin/grep --color=tty" ... > and other executables in Eshell with "export TERM=eshell-color", they > all work great. > > So we can safely export eshell's "TERM" with `eshell-term-name` to > support executables with colors. > I attached the patch, please help review it. Thanks. Thanks. The fact that we can safely do that does not yet mean we _should_ do it. In my book, setting TERM is a user preference, more or less. IOW, this is a change in the default behavior. Jim, WDYT?