From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#70577: [PATCH] New command other-project-prefix Date: Sun, 05 May 2024 19:40:14 +0300 Organization: LINKOV.NET Message-ID: <865xvsjklh.fsf@mail.linkov.net> References: <86le501ykg.fsf@mail.linkov.net> <86jzkhe81b.fsf@mail.linkov.net> <208c7a05-6cfe-40c2-af54-187967348686@gutov.dev> <86le4tz88d.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12917"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 70577@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 18:45:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3ezE-000393-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 18:45:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3eys-0000CL-4w; Sun, 05 May 2024 12:44:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3eye-00006D-M5 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 12:44:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3eye-0007lT-1n for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 12:44:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3ez1-0001bB-K5 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 12:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 16:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70577-submit@debbugs.gnu.org id=B70577.17149274986101 (code B ref 70577); Sun, 05 May 2024 16:45:03 +0000 Original-Received: (at 70577) by debbugs.gnu.org; 5 May 2024 16:44:58 +0000 Original-Received: from localhost ([127.0.0.1]:60621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3eyw-0001aL-0H for submit@debbugs.gnu.org; Sun, 05 May 2024 12:44:58 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3eyu-0001Zp-0I for 70577@debbugs.gnu.org; Sun, 05 May 2024 12:44:56 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 22887E0005; Sun, 5 May 2024 16:44:24 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sat, 4 May 2024 05:12:39 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284514 Archived-At: > We would want 'C-h' to show the regular buffer with key bindings, won't we? > With similar output to the one that we get after 'C-x p C-h' or 'C-x > v C-h'. The output might be weirder because of the composed keymap, but it > could still be useful. Then maybe something like (define-key map (vector help-char) (lambda () (interactive) (describe-bindings))) or (define-key map (vector help-char) (lambda () (interactive) (describe-keymap (cons 'keymap (current-active-maps))))) or (define-key map (vector help-char) (lambda () (interactive) (describe-keymap (cons 'keymap project-prefix-map)))) >> However, a much bigger problem is that unfortunately many test cases from >> https://debbugs.gnu.org/63648#203 are broken. For example, >> 'C-x p p C-b' fails the same way as in bug#58784. >> 'C-x p p f M-n' fails because it expects to read arguments >> in a previous project with an old value of default-directory, etc. > > Thanks for noticing. Looks like the call to project-prompter can change the > value of this-command, and that's why the subsequent check went down the > wrong branch. See the attached v3 with the fix. Wow, everything works now, will test more as a primary 'C-x p p' command.