all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: spacibba@aol.com, emacs-devel@gnu.org
Subject: Re: A few questions about c++-ts-mode.
Date: Wed, 08 May 2024 16:35:52 +0300	[thread overview]
Message-ID: <865xvoa0jr.fsf@gnu.org> (raw)
In-Reply-To: <C23BC107-2EAA-4854-9C46-A5569CF11897@gmail.com> (message from Yuan Fu on Tue, 7 May 2024 17:19:53 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 7 May 2024 17:19:53 -0700
> Cc: emacs-devel@gnu.org
> 
> > 1. namespaces are not fontified like in c-mode (i.e in std::string the
> >  `std` used to have font-lock-constant-face while `string` used to have
> >  font-lock-type-face). It seems like tresitter identifies properly them
> >  like (namespace_identifier) and (type_identifier)
> 
> Then we probably want to fontify namespaces in constant face. Or perhaps add a namespace-face that inherits from constant face.

I think using font-lock-constant-face is fine.  Patches welcome.

> > 2. Doc string comments are fontified like normal comments. It looks like
> >  treesiter does not recognize them at all. Is this something we need to
> >  report to treesitter or we need to workaround it in emacs side?
> 
> I’m working on that. I think the best way is to workaround it in Emacs.

Please note that some of those specially-formatted comments are
explicitly supported by the grammar.

> > 3. macros like `#if defined(something)` fontifies the whole macro with
> >  same font (the `identifier` used to have no colors in c++-mode)
> 
> We should update the fontification to leave out the identifier.

We seem to have the technology already, but we are overwriting it?
Observe:

     (preproc_defined) @font-lock-preprocessor-face
     (preproc_defined (identifier) @font-lock-variable-name-face)
     [,@c-ts-mode--preproc-keywords] @font-lock-preprocessor-face)



  parent reply	other threads:[~2024-05-08 13:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fakigaygsqcunvvbm2zscn7qlkxi234f574ul3hl5vrhymm22k.ref@syjmsievkpp3>
2024-05-07 22:59 ` A few questions about c++-ts-mode Ergus
2024-05-08  0:19   ` Yuan Fu
2024-05-08  1:26     ` Ergus
2024-05-09  4:29       ` Yuan Fu
2024-05-09  6:18         ` Filippo Argiolas
2024-05-12 20:11         ` Ergus
2024-05-08 13:35     ` Eli Zaretskii [this message]
2024-05-08 21:05       ` Ergus
2024-05-09  0:16         ` Yuan Fu
2024-05-09  5:17           ` Eli Zaretskii
2024-05-09  5:03         ` Eli Zaretskii
2024-05-09  5:34           ` Filippo Argiolas
2024-05-09  5:53             ` Eli Zaretskii
2024-05-09  6:11               ` Filippo Argiolas
2024-05-09  7:03                 ` Eli Zaretskii
2024-05-13  6:23               ` Filippo Argiolas
2024-05-13  8:10                 ` Filippo Argiolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xvoa0jr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.