From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 49e243c0c85: Avoid resizing mutation in subst-char-in-string, take two
Date: Mon, 13 May 2024 20:53:44 +0300 [thread overview]
Message-ID: <865xvhy4wn.fsf@gnu.org> (raw)
> + (if (and (not inplace)
> + (if (multibyte-string-p string)
> + (> (max fromchar tochar) 127)
> + (> tochar 255)))
Is the above condition correct? My reading of it is that if INPLACE
is non-nil, we use aset (which will resize a string) even if TOCHAR
needs more bytes than FROMCHAR. Which seems to be in contradiction
with the goal of the change, as advertised by the log message: "avoid
resizing mutation". Did I miss something?
Btw, why, in the case of a multibyte STRING, does the code look at the
codepoints of FROMCHAR and TOCHAR and not at the number of bytes they
take in the internal Emacs representation of the characters?
next reply other threads:[~2024-05-13 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 17:53 Eli Zaretskii [this message]
2024-05-13 19:20 ` master 49e243c0c85: Avoid resizing mutation in subst-char-in-string, take two Mattias Engdegård
2024-05-14 6:06 ` Eli Zaretskii
2024-05-14 10:44 ` Mattias Engdegård
2024-05-14 11:35 ` Eli Zaretskii
2024-05-15 12:29 ` Mattias Engdegård
2024-05-15 12:40 ` Eli Zaretskii
2024-05-15 17:29 ` Mattias Engdegård
2024-05-15 18:15 ` Eli Zaretskii
2024-05-15 20:19 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865xvhy4wn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.