From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71472: [PATCH] Add pty support by using ConPTY on Windows Date: Tue, 11 Jun 2024 11:42:02 +0300 Message-ID: <865xuf7twl.fsf@gnu.org> References: <874ja1m6u1.fsf@zohomail.jp> <86jziw956n.fsf@gnu.org> <190055cd3c0.5289e49215028.2058921479589116968@zohomail.jp> <86ed946it3.fsf@gnu.org> <19006667d08.6141650b15233.4287906273312116966@zohomail.jp> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5027"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71472@debbugs.gnu.org To: Ke Wu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 11 22:26:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH84G-00014T-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jun 2024 22:26:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sH83T-0007ih-4Y; Tue, 11 Jun 2024 16:25:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH83G-0007dO-2e for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 16:25:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sH83F-0003TH-LS for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 16:25:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sH83D-0002mn-SC for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 16:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2024 20:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71472-submit@debbugs.gnu.org id=B71472.171813745410553 (code B ref 71472); Tue, 11 Jun 2024 20:25:03 +0000 Original-Received: (at 71472) by debbugs.gnu.org; 11 Jun 2024 20:24:14 +0000 Original-Received: from localhost ([127.0.0.1]:36381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82Q-0002k3-Ct for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82M-0002i3-Tw for 71472@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGx4x-0006Xq-BF; Tue, 11 Jun 2024 04:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h0YDBv8Kx2X3XzAJA2Z7bCp/znk2X+VxfKq+CXFzoX4=; b=Mo7dEIWZ3MAT kYPIVd+oAjsH7htugP1P9lSkt3T2fcMUr/79SdDg2G8apqKC8q3A8mTTfV45hFigXHAhndnwHpPWc kApLj+XG9jlX0UZOs6/Xep0nlHHW3Y3fFjjqbi+1dVMLPvDG5t06LJo5/BmzLI1MJNW4nfte6rP1q l01OXHVBdmAnGdtgkuykJEqA+VBlUw/IGCEKu1X5cjEgoCyItGnzKZTwqhuyRXxR3Z2ENahr5FgwD v24u2w5AcoYSH3wtXZKTkjeAqMfpcO5rcFhUNf51nAelDOS2aXhGyhSNMgtDFpgLFjN2I2sWfm2HQ HGEn2PzyE2QpC9GERvfUFg==; In-Reply-To: <19006667d08.6141650b15233.4287906273312116966@zohomail.jp> (message from Ke Wu on Tue, 11 Jun 2024 17:24:58 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287120 Archived-At: > Date: Tue, 11 Jun 2024 17:24:58 +0900 > From: Ke Wu > Cc: "71472" <71472@debbugs.gnu.org> > > Thank you for your detailed explanation. The patch itself cannot provide > a satisfying pty support on Windows. Its original purpose is to provide > support to term.el and other packages which setup a terminal emulator > inside Emacs. It is not meant to be a replacement of `make-process` on > Windows, but is used as a supplementary method to patch the broken > term.el, which has long been an issue for Windows users. OK, that narrows the applicability and thus the extent of possible problems. But still some problems remain: does that work with running in "M-x term" programs that display fancy/unusual characters? Did you try that with Git, for example, showing changes whose authors or text of the diffs include Unicode characters? Or what happens if you run the DIR command of cmd.exe in a directory which has files whose names aren't supported by the system codepage? Or what happens if you run a program whose command-line arguments include characters not supported by the current system codepage? IOW, we must understand the limitations of this before we decide whether this feature is justified. Installing features with too many limitations will annoy the users and cause complaints and bug reports. Thanks.