From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fa4203300fd: Merge remote-tracking branch 'origin/feature/which-key-in-core' Date: Wed, 19 Jun 2024 17:41:13 +0300 Message-ID: <865xu5ov06.fsf@gnu.org> References: <171873998859.23986.6867742580209068033@vcs2.savannah.gnu.org> <20240618194635.AC606C1FB66@vcs2.savannah.gnu.org> <8734p9z9d0.fsf@gmail.com> <878qz1l6p3.fsf@posteo.net> <87y171xqoq.fsf@gmail.com> <87tthpxhto.fsf@gmail.com> <868qz1oz7k.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35244"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, philipk@posteo.net, emacs-devel@gnu.org To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 19 16:42:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJwVt-0008wg-4J for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jun 2024 16:42:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJwV0-0006eh-CM; Wed, 19 Jun 2024 10:41:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJwUz-0006eI-Bl for emacs-devel@gnu.org; Wed, 19 Jun 2024 10:41:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJwUy-00056i-NH; Wed, 19 Jun 2024 10:41:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CqzVZ0srCB0BKMdV4whQJBdqWgQQIivjApuw35GVX4w=; b=huyBTgAvubUF MX0VhPZz0igoZeFxlMuHFSty7S8bz/PIAKXFl6xqgmQ7WJkwKu/rF5gpOxQBFmk/8nKAoa0IgY5tZ EFbUuH2RajKu7qM6i0+OpFboVDgIAdgc4ropT+8rToPQ3eZ4k1+zMkinNnU6WTerfEHchH7Me10XU puoy5vuBHG2SlCP/dnKA35etnXb7wViVxDG2BkH8yhgqr0fJucnibHvF2hhcESI59z4hNdItwH11Q vGOLhNtYSjXVjDX9EY0lSaoasF3ouUUW/HgPyYu31knohHLURORdpNTfK595VrawGyaVlW5BF2DQ6 FEt/pmnR8yOKGTWhW7K9bw==; In-Reply-To: (tomas@tuxteam.de) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320298 Archived-At: > Date: Wed, 19 Jun 2024 15:37:20 +0200 > Cc: Robert Pluim , philipk@posteo.net, > emacs-devel@gnu.org > From: > > On Wed, Jun 19, 2024 at 04:10:23PM +0300, Eli Zaretskii wrote: > > [...] > > > What's the downside of doing this unconditionally? > > You mean enabling "which-key" unconditionally? No, showing keys from other maps. That's what you were suggesting to have an option for, no? The option for turning on and off which-key already exists, so discussing its necessity sounds redundant, no?