From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Proposal: new default bindings for winner and windmove Date: Tue, 02 Jul 2024 16:34:27 +0300 Message-ID: <865xtndijg.fsf@gnu.org> References: <875xto7lbn.fsf@dancol.org> <86tth8c7h4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, stefankangas@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 15:34:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOdeq-0001Ag-Lm for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 15:34:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOdeU-0003EG-Qh; Tue, 02 Jul 2024 09:34:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOdeR-0003De-Se for emacs-devel@gnu.org; Tue, 02 Jul 2024 09:34:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOdeR-0000DD-FL; Tue, 02 Jul 2024 09:34:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eeA0SdeFPWkergfkuAzPAAfXYJKbLfORIi2HJAHAqFM=; b=R4vQmSw9sWHG eaAuOLkGBpWa9Re6vGhRZ9jyHEq0pULYJ+esIA7T1foFZOUZ1EPV7c3/1oLh7yEhkOXUheY0BaZTV Mp0+KAhw7aMILaFnrsyrdnTCYYfzjfwzQAMs4ccwzoMinBfVEXK03+9UwCAi99y5QVS0/o6LROG2Q bqbgJTevzYW9iVIZtTNR3m416gX65UtcD4VzUOmCMOksURGNcBWGVMG9jBE9xykF7J9obdWQHWAex dDdgG2P+zT4UGF/yRQmRwQeoVE6EZhM2Aeql2vx4fJxZCV91h8QpGn25eXDcIQcgxoBKRyQsybAG7 zVh7gtsg8ynUcrgzdjvkqA==; In-Reply-To: (message from Daniel Colascione on Tue, 02 Jul 2024 08:52:54 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321152 Archived-At: > Date: Tue, 02 Jul 2024 08:52:54 -0400 > From: Daniel Colascione > CC: stefankangas@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org > > > > On July 2, 2024 8:18:47 AM EDT, Eli Zaretskii wrote: > >> Cc: Stefan Kangas , Stefan Monnier > >> , emacs-devel@gnu.org > >> Date: Tue, 02 Jul 2024 09:02:12 +0800 > >> From: Po Lu via "Emacs development discussions." > >> > >> Daniel Colascione writes: > >> > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [left] 'windmove-left) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [right] 'windmove-right) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [up] 'windmove-up) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [down] 'windmove-down) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [(shift left)] 'windmove-swap-states-left) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [(shift right)] 'windmove-swap-states-right) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [(shift up)] 'windmove-swap-states-up) > >> > +;;;###autoload > >> > +(define-key ctl-x-4-map [(shift down)] 'windmove-swap-states-down) > >> > + > >> > > > >> > (provide 'windmove) > >> > > >> > >> Disabling windmove-mode must disable these bindings as well. > > > >I tend to agree. > > What use would it be to disable these bindings? It's cleaner, IMO: disabling a mode cleans up after the mode. Not an "over my dead body" kind of issue, obviously, but still.