From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Date: Thu, 25 Jul 2024 21:18:57 +0300 Organization: LINKOV.NET Message-ID: <865xstibce.fsf@mail.linkov.net> References: <87le2kaloz.fsf@breatheoutbreathe.in> <861q4ce1yb.fsf@mail.linkov.net> <877ce3damx.fsf@breatheoutbreathe.in> <86r0cb7l58.fsf@mail.linkov.net> <5aff3095-087f-493d-9251-8048b51280f9@alphapapa.net> <86msmzc7ne.fsf@mail.linkov.net> <86o77dox54.fsf@mail.linkov.net> <87a5ihgii9.fsf@breatheoutbreathe.in> <86jzhkgtb7.fsf@gnu.org> <865xt1lw66.fsf@mail.linkov.net> <87ikwttk96.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: adam@alphapapa.net, 71883@debbugs.gnu.org, Eli Zaretskii , shipmints@gmail.com To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 25 20:24:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sX38Q-0004hf-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jul 2024 20:24:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sX38D-00071Q-PB; Thu, 25 Jul 2024 14:24:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sX386-000704-Dy for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:23:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sX386-00039J-5g for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:23:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sX38D-0003Vp-Kv for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2024 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71883-submit@debbugs.gnu.org id=B71883.172193178313412 (code B ref 71883); Thu, 25 Jul 2024 18:24:01 +0000 Original-Received: (at 71883) by debbugs.gnu.org; 25 Jul 2024 18:23:03 +0000 Original-Received: from localhost ([127.0.0.1]:37751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX37H-0003UG-6a for submit@debbugs.gnu.org; Thu, 25 Jul 2024 14:23:03 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:50837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX37E-0003TK-Jz for 71883@debbugs.gnu.org; Thu, 25 Jul 2024 14:23:01 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8D90FE0002; Thu, 25 Jul 2024 18:22:23 +0000 (UTC) In-Reply-To: <87ikwttk96.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Thu, 25 Jul 2024 11:11:01 -0700") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289329 Archived-At: >> Replacing hard-coded logic with customizable variable >> for external packages like activities.el is needed >> as soon as possible on emacs-30 because hard-coded logic >> hinders the use of packages. >> >> However, there is no hurry to change the default behavior >> to match a symbol name instead of checking face names. >> Therefore I think better to move the existing code >> >> (memq (get-text-property 0 'face (nth 2 item)) tab-bar-auto-width-faces) >> >> to the new predicate function on emacs-30. Then activities.el >> can change it to another function that matches a symbol. >> >> Then on master the default body on the new predicate >> could be replaced from checking the face to match a symbol. >> Also changes in tab-bar--format-tab-group should be on master as well. > > Much as I'd like to use these changes asap, I think this patchset should > go entirely on master. I see these changes as adding functionality > (making tab-bar tabs more extensible) rather than bug fixes. Are you sure there is no hurry to make tab-bar more extensible for activities.el? Then let's push to master for Emacs 31.