From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74474: 30.0.92; treesit-defun-prefer-top-level is still used in js, ruby-ts-mode, typescript-ts-mode, c-ts-mode and php-ts-mode Date: Fri, 22 Nov 2024 16:08:03 +0200 Message-ID: <865xofnyyk.fsf@gnu.org> References: <1951718.7Z3S40VBb9@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38692"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74474@debbugs.gnu.org To: Vincenzo Pupillo , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 22 15:09:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEULq-0009sM-OP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Nov 2024 15:09:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEULO-0007Uq-Tw; Fri, 22 Nov 2024 09:09:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEULH-0007UR-JQ for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 09:09:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEULG-00031W-Sc for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 09:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=r19Zb/BqWmJZRFC9+hb2fM+yivG/x7RQdyDXkRxx0Eg=; b=eLiD2O7jASJ9A/0GWMuaTulUKCDoSUvrYjRKCki50tYbZIh+9qQFnXTc3Ebj7bGsBfKJYeTmxkEyE8bhc0CNtcyQ08iVk7MJBhovVsAVcKXrRhq4SQvFYTJ3NK2fWM9L3c5ojCholMeqQsG4PQZ9e11VYPdMuiUfjZcz5LEYGtC6oY/03jwcESRoe9yvfAsiZ0zJRGFfRL4pjGT58ou/JI4eotxiYZb7KB56L/XQxpUGJXrqoYCB82wT6AKPpIPErH75CoXNndXyFxy6QI3su7TNot0sXj9yWhsRY1CjbR3WKuSF/bc/2SJmbz5BAjBWR22CEiV9TSJEbLX2KLunNw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEULG-0003z8-Ju for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2024 09:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2024 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74474 X-GNU-PR-Package: emacs Original-Received: via spool by 74474-submit@debbugs.gnu.org id=B74474.173228450215268 (code B ref 74474); Fri, 22 Nov 2024 14:09:02 +0000 Original-Received: (at 74474) by debbugs.gnu.org; 22 Nov 2024 14:08:22 +0000 Original-Received: from localhost ([127.0.0.1]:53718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEUKb-0003yA-8o for submit@debbugs.gnu.org; Fri, 22 Nov 2024 09:08:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEUKV-0003xr-LX for 74474@debbugs.gnu.org; Fri, 22 Nov 2024 09:08:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEUKQ-0002tR-9d; Fri, 22 Nov 2024 09:08:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=r19Zb/BqWmJZRFC9+hb2fM+yivG/x7RQdyDXkRxx0Eg=; b=dmVtakWgixsA tITeCdIiUZ2PYSXZYiGYiGauDXePbpLtVp2102pvCH2z7M9FSTEeJyKmD8kgNxrIntLUZMsNdC1R5 mhHo4zCUatxz+24+xJUkOP3r5phoFQLGPBX1JmSq9+KCiZUvcM4s1Ou8EgFrZr/vWeu8OrMh7RYAB XSYwwcfkNkbyoWQgjGzL/N/8D1aAfeGnv6p7MHZQA/A2Uil4rMTmThX81VB3h5ItFzqXRnUy9tKmv AWL7rAvnjJ/AEFbNLFfendvl4yB+WzUp6nfXYLIEesWg4J/fWZShgPYYWy6Zt/K8ExttFGUGDFmit 8Z1NZ/HFmSOztl/WKXkLJQ==; In-Reply-To: <1951718.7Z3S40VBb9@fedora> (message from Vincenzo Pupillo on Fri, 22 Nov 2024 14:35:50 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295795 Archived-At: > From: Vincenzo Pupillo > Date: Fri, 22 Nov 2024 14:35:50 +0100 > > Ciao, > I am writing a treesitter-based version of mhtml (email threads https:// > lists.gnu.org/archive/html/emacs-devel/2024-11/msg00079.html). > I started from what I did for php-ts-mode. > In php-ts-mode the variable treesit-defun-prefer-top-level is initialized to > t. > This variable, whose use I had borrowed from c-ts-mode, no longer exists. > >From the Changelog.4 : > 2022-12-19 Stefan Kangas > > Merge from origin/emacs-29 > > 67bc96c9d94 Remove treesit-defun-prefer-top-level and friends > 4f9bccef556 Add yaml-ts-mode (Bug#60105) > f9cb144d45a Fix indentation in json-ts-mode (bug#60123) > 3d348c46e78 ; Handle nil ARG in treesit-beginning/end-of-defun > 1a66435dda3 New input method 'cyrillic-chuvash' > b9227c502d7 ; Improve wording of 'format' doc string > > This variable is also used by other major modes, with different value: > > lisp/progmodes/c-ts-mode.el > 1259: (setq-local treesit-defun-prefer-top-level t) > > lisp/progmodes/typescript-ts-mode.el > 465: (setq-local treesit-defun-prefer-top-level t) > > lisp/progmodes/ruby-ts-mode.el > 1202: (setq-local treesit-defun-prefer-top-level nil) > > lisp/progmodes/js.el > 3919: (setq-local treesit-defun-prefer-top-level t) > > treesit-defun-prefer-top-level should have been replaced by treesit-defun- > tactic which, however, is initialized by default with a value that should > match only (setq treesit-defun-prefer-top-level nil). > > Is it possible that this is related to problems similar to those indicated in > bug#73404? Yuan, any comments?