all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: michael_heerdegen@web.de, 74700@debbugs.gnu.org
Subject: bug#74700: [PATCH] Revert Dired buffer when clicking on last segment of directory name
Date: Thu, 26 Dec 2024 10:56:48 +0200	[thread overview]
Message-ID: <865xn6zusv.fsf@gnu.org> (raw)
In-Reply-To: <87r05w9xmo.fsf@gmail.com> (message from Visuwesh on Wed, 25 Dec 2024 10:17:59 +0530)

> From: Visuwesh <visuweshm@gmail.com>
> Cc: 74700@debbugs.gnu.org,  eliz@gnu.org
> Date: Wed, 25 Dec 2024 10:17:59 +0530
> 
> [புதன் டிசம்பர் 25, 2024] Michael Heerdegen wrote:
> 
> >> However, using mouse-1 still moves the point to bob.  I believe we
> >> could fix it by directly binding mouse-1 but I would like to respect
> >> mouse-1-click-follows-link like the rest of the code in the function.
> >> I cannot tell how to prevent mouse-1 from moving point reading the
> >> Info nodes (info "(elisp) Clickable Text") and (info "(emacs) Mouse
> >> References").  I tried
> >>
> >>     (with-selected-window (posn-window (event-start e)) ...)
> >>
> >> to no avail.
> >
> > Was that code line the attempt to fix the problem that the buffer in the
> > wrong window was being reverted, or the attempt to fix the mouse-1
> > problem?
> 
> It was an attempt to fix the mouse-1 problem.  The former issue is fixed
> with the following patch.
> 
> >> This goes beyond my level of knowledge so someone else will have to
> >> take care of this.  But please install the following patch because
> >> without it using mouse-2 on the base name tries to revert the
> >> current-buffer instead of the dired buffer when the dired buffer is
> >> not shown in the selected window.
> >
> >> +++ #<buffer dired.el>
> >> @@ -2089,8 +2089,10 @@
> >>             `( mouse-face highlight
> >>                help-echo "mouse-1: revert this buffer"
> >>                keymap ,(define-keymap
> >> -                        "<mouse-2>" #'revert-buffer
> >> -                        "<follow-link>" 'follow-link
> >> +                        "<mouse-2>" (lambda (_)
> >> +                                      (interactive "@e")
> >> +                                      (revert-buffer))
> >> +                        "<follow-link>" 'mouse-face
> >
> > I don't know how to fix the mouse-1 problem in a sensible way either.
> > Does anyone?
> >
> > (And I think in this version the "e" code in `interactive' isn't
> > significant - but let's first see if we can improve the behavior even
> > more.)
> 
> Indeed, I thought @ had to go with e _always_.

Thanks, so please post a proper patch with a commit log message, so I
could install it.





  reply	other threads:[~2024-12-26  8:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05  6:12 bug#74700: [PATCH] Revert Dired buffer when clicking on last segment of directory name Visuwesh
2024-12-05  7:02 ` Eli Zaretskii
2024-12-05  8:26   ` Visuwesh
2024-12-05  8:41     ` Eli Zaretskii
2024-12-05  9:02       ` Visuwesh
2024-12-05  9:24         ` Eli Zaretskii
2024-12-05 10:42           ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-05 17:56         ` Juri Linkov
2024-12-12 10:31     ` Eli Zaretskii
2024-12-23 21:31       ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-24  3:22         ` Visuwesh
2024-12-24 23:39           ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25  3:43             ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25  4:47             ` Visuwesh
2024-12-26  8:56               ` Eli Zaretskii [this message]
2024-12-26 11:51                 ` Visuwesh
2024-12-26 12:08                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xn6zusv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74700@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.