From: David Kastrup <dak@gnu.org>
To: rms@gnu.org
Cc: martin rudalics <rudalics@gmx.at>,
jan.h.d@swipnet.se, emacs-devel@gnu.org
Subject: Re: [jbw@macs.hw.ac.uk: window-min-height not obeying its documentation in Emacs 22.1]
Date: Tue, 10 Jul 2007 09:13:58 +0200 [thread overview]
Message-ID: <864pkc20jt.fsf@lola.quinscape.zz> (raw)
In-Reply-To: <E1I88QR-00012w-MF@fencepost.gnu.org> (Richard Stallman's message of "Tue\, 10 Jul 2007 01\:38\:15 -0400")
Richard Stallman <rms@gnu.org> writes:
> Your change is clean and clear that I could only find the tiniest nit
> to criticize:
>
> ! && (window_height (window) >=
> ! window_min_size_2 (XWINDOW (window), 0) << 1))
>
> Please break the line before the >= operator, not after.
I'd write * 2 instead of << 1 here.
--
David Kastrup
next prev parent reply other threads:[~2007-07-10 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 4:24 [jbw@macs.hw.ac.uk: window-min-height not obeying its documentation in Emacs 22.1] Richard Stallman
2007-07-09 12:03 ` Jan Djärv
2007-07-09 17:51 ` martin rudalics
2007-07-10 5:38 ` Richard Stallman
2007-07-10 7:13 ` David Kastrup [this message]
2007-07-10 22:01 ` Richard Stallman
2007-07-10 12:11 ` martin rudalics
2007-07-10 22:01 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864pkc20jt.fsf@lola.quinscape.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=rms@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.