From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: master d05806f: alas, a map can have only one parent Date: Mon, 02 May 2016 12:28:49 -0400 Organization: disorganization Message-ID: <864magwhj2.fsf@gnu.org> References: <20160502154807.20012.10005@vcs.savannah.gnu.org> <87h9egwiud.fsf@gnus.org> Reply-To: sds@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462206619 15930 80.91.229.3 (2 May 2016 16:30:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 May 2016 16:30:19 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 02 18:30:01 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axGjR-0006sH-2g for ged-emacs-devel@m.gmane.org; Mon, 02 May 2016 18:30:01 +0200 Original-Received: from localhost ([::1]:37575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axGjN-0001cF-5H for ged-emacs-devel@m.gmane.org; Mon, 02 May 2016 12:29:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axGiv-00016M-Iu for emacs-devel@gnu.org; Mon, 02 May 2016 12:29:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axGij-0007BJ-Mu for emacs-devel@gnu.org; Mon, 02 May 2016 12:29:24 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:58768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axGij-00078I-GK for emacs-devel@gnu.org; Mon, 02 May 2016 12:29:17 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1axGiZ-0006PE-0b for emacs-devel@gnu.org; Mon, 02 May 2016 18:29:07 +0200 Original-Received: from 69.74.59.115 ([69.74.59.115]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 May 2016 18:29:06 +0200 Original-Received: from sds by 69.74.59.115 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 May 2016 18:29:06 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69.74.59.115 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Cancel-Lock: sha1:RhMriKGpWL9TZibvuiQo/+O/D/A= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203524 Archived-At: > * Lars Ingebrigtsen [2016-05-02 18:00:26 +0200]: > > Sam Steingold writes: > >> alas, a map can have only one parent >> >> * lisp/image-mode.el (image-model-map): Cannot have two parents. >> * lisp/image.el (image-map): Inherit from `special-mode-map'. > > This is the definition of image-mode-map: > > (defvar image-mode-map > (let ((map (make-sparse-keymap))) > ... > (make-composed-keymap (list map image-map) special-mode-map)) > > Which should take care of the multiple inheretance. > > And image-map should certainly not inherit anything from > special-mode-map. > > So I think your patch is wrong. What are you trying to fix? `q' in image-mode was not bound. -- Sam Steingold (http://sds.podval.org/) on Ubuntu 16.04 (xenial) X 11.0.11803000 http://www.childpsy.net/ http://truepeace.org http://iris.org.il http://openvotingconsortium.org http://memri.org http://www.memritv.org A computer scientist is someone who fixes things that aren't broken.