* Re: master d05806f: alas, a map can have only one parent
[not found] ` <E1axG4t-0005DO-Ve@vcs.savannah.gnu.org>
@ 2016-05-02 16:00 ` Lars Ingebrigtsen
2016-05-02 16:28 ` Sam Steingold
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2016-05-02 16:00 UTC (permalink / raw)
To: emacs-devel; +Cc: Sam Steingold
Sam Steingold <sds@gnu.org> writes:
> alas, a map can have only one parent
>
> * lisp/image-mode.el (image-model-map): Cannot have two parents.
> * lisp/image.el (image-map): Inherit from `special-mode-map'.
This is the definition of image-mode-map:
(defvar image-mode-map
(let ((map (make-sparse-keymap)))
...
(make-composed-keymap (list map image-map) special-mode-map))
Which should take care of the multiple inheretance.
And image-map should certainly not inherit anything from
special-mode-map.
So I think your patch is wrong. What are you trying to fix?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master d05806f: alas, a map can have only one parent
2016-05-02 16:00 ` master d05806f: alas, a map can have only one parent Lars Ingebrigtsen
@ 2016-05-02 16:28 ` Sam Steingold
2016-05-02 16:32 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Sam Steingold @ 2016-05-02 16:28 UTC (permalink / raw)
To: emacs-devel
> * Lars Ingebrigtsen <ynefv@tahf.bet> [2016-05-02 18:00:26 +0200]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> alas, a map can have only one parent
>>
>> * lisp/image-mode.el (image-model-map): Cannot have two parents.
>> * lisp/image.el (image-map): Inherit from `special-mode-map'.
>
> This is the definition of image-mode-map:
>
> (defvar image-mode-map
> (let ((map (make-sparse-keymap)))
> ...
> (make-composed-keymap (list map image-map) special-mode-map))
>
> Which should take care of the multiple inheretance.
>
> And image-map should certainly not inherit anything from
> special-mode-map.
>
> So I think your patch is wrong. What are you trying to fix?
`q' in image-mode was not bound.
--
Sam Steingold (http://sds.podval.org/) on Ubuntu 16.04 (xenial) X 11.0.11803000
http://www.childpsy.net/ http://truepeace.org http://iris.org.il
http://openvotingconsortium.org http://memri.org http://www.memritv.org
A computer scientist is someone who fixes things that aren't broken.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master d05806f: alas, a map can have only one parent
2016-05-02 16:28 ` Sam Steingold
@ 2016-05-02 16:32 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2016-05-02 16:32 UTC (permalink / raw)
To: emacs-devel
Sam Steingold <sds@gnu.org> writes:
> `q' in image-mode was not bound.
Are you sure? It works for me before you added your patch. (It was
fixed about a week ago, I think.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-02 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160502154807.20012.10005@vcs.savannah.gnu.org>
[not found] ` <E1axG4t-0005DO-Ve@vcs.savannah.gnu.org>
2016-05-02 16:00 ` master d05806f: alas, a map can have only one parent Lars Ingebrigtsen
2016-05-02 16:28 ` Sam Steingold
2016-05-02 16:32 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.