all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] Improve Gravatar support
Date: Tue, 23 Jul 2019 09:36:16 +0100	[thread overview]
Message-ID: <864l3di1vj.fsf@gmail.com> (raw)
In-Reply-To: 878ssp6918.fsf@tcd.ie

On Mon 22 Jul 2019, Basil L. Contovounesios wrote:

> Andy Moreton <andrewjmoreton@gmail.com> writes:
>
>> On Mon 22 Jul 2019, Basil L. Contovounesios wrote:
>>
>>> The attached patch adds support for more Gravatar features, improves
>>> existing docs, and reduces some code duplication.  WDYT?
>>
>> This patch seems to mix three things:
>>  - conversion to lexical binding
>>  - minor bugfixes
>>  - new features
>>
>> It is better to put each in a separate patch, to ease later bisection if
>> needed.
>
> More often I see reviewers express the opposite feeling here, but since
> I don't personally mind and you asked so nicely:

Thanks. A series of simple patches is easier to review than a longer
patch that mixes several logical changes, and bisection is more likely
to return a useful answer.

The patches look good to me,

    AndyM




  parent reply	other threads:[~2019-07-23  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 13:23 [PATCH] Improve Gravatar support Basil L. Contovounesios
2019-07-22 13:31 ` Lars Ingebrigtsen
2019-07-22 21:44   ` Basil L. Contovounesios
2019-07-23 11:29     ` Lars Ingebrigtsen
2019-07-22 13:39 ` Andy Moreton
2019-07-22 21:42   ` Basil L. Contovounesios
2019-07-23  2:31     ` Eli Zaretskii
2019-07-23  8:36       ` Basil L. Contovounesios
2019-07-23  8:36     ` Andy Moreton [this message]
2019-07-23  9:18       ` Basil L. Contovounesios
2019-08-02 13:45     ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864l3di1vj.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.