From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: parser error recovery algorithm vs treesit indentation "blinking" Date: Tue, 04 Apr 2023 06:50:30 -0700 Message-ID: <864jpvvjrt.fsf@stephe-leake.org> References: <87lejgsf0m.fsf@gmail.com> <83pm8s70o3.fsf@gnu.org> <83mt3u65vw.fsf@gnu.org> <87y1newqus.fsf@gmail.com> <83bkka5z7w.fsf@gnu.org> <871ql6a4d4.fsf@gmail.com> <83jzyy4776.fsf@gnu.org> <9F152CAA-6326-459F-84FF-87988B3A92B6@gmail.com> <868rf8vdse.fsf_-_@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , Yuan Fu , Eli Zaretskii , theodor thornhill , geza.herman@gmail.com, Daniel Colascione , emacs-devel@gnu.org To: John Yates Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 04 15:51:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjh4L-0006Xa-AZ for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Apr 2023 15:51:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjh3Z-00083A-Bd; Tue, 04 Apr 2023 09:50:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjh3X-00082T-Qp for emacs-devel@gnu.org; Tue, 04 Apr 2023 09:50:39 -0400 Original-Received: from outbound-ss-820.bluehost.com ([69.89.24.241]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjh3T-0000e3-QA for emacs-devel@gnu.org; Tue, 04 Apr 2023 09:50:37 -0400 Original-Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id B8B2C1004853B for ; Tue, 4 Apr 2023 13:50:32 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id jh3QpiE64NX2ajh3QpMR2B; Tue, 04 Apr 2023 13:50:32 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=642c2b28 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=P-ICsynqAAAA:8 a=9i_RQKNPAAAA:8 a=wOc6KdgATogKr4ahMrAA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=Kq4uwMxLpIWLwKroyo8M:22 a=Ev4oQ7kfJBNsvnoXShoW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tIrPdFIXvjYUPNT8xQxTn0capD0w/7KeFVcTy4GIunE=; b=lVQEIp084sPZXftULY8e4EGm5c JuOf7jCCZGhp6Ml8E83dzMsx4CEcP4oo21dN4CvIzLtSCkW42E3X0n0EeEuaDDMiurCi2QEcjs+7x H35QWOPe8cBjLoP5eGYg+NFmXm2QfPSFRDS2dNLlEdaubtyzYoBK7cdP5ZzW/1RKhmFOoTPgtVl67 pFE5urrseGGc1OfXh66/gCwXkOuaM7gTyCLz1sDAv7se5nm0vMEtkUVHHOOwrYTtoKiS6RtLuZ+b6 2sKNlXNfkYshivnC0nb2aqYDh5vCKPB7gPeqFa4evV5GYTllLYCJljpILY56VIaRt/qkLSp9EugT5 BpG3RqrQ==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:52175 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pjh3P-003WfK-RP; Tue, 04 Apr 2023 07:50:31 -0600 In-Reply-To: (John Yates's message of "Tue, 4 Apr 2023 08:01:07 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1pjh3P-003WfK-RP X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:52175 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 8 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=69.89.24.241; envelope-from=stephen_leake@stephe-leake.org; helo=outbound-ss-820.bluehost.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305107 Archived-At: John Yates writes: > On Mon, Apr 3, 2023 at 5:49=E2=80=AFPM Stephen Leake > wrote: >> >> That's because the tree-sitter >> algorithm does not insert symbols, it only skips them. > > Is this a fundamental architectural limitation of tree-sitter's parsing > scheme?=20=20 Possibly. In the wisitoken parser, allowing insertions during error correction significantly complicates the edit step of incremental parsing - so much so that there are still bugs in the wisitoken parser that I'm having a very hard time squashing. > Was it a design decision that trying insertions would be too costly? I don't know. There are some references on error correction on the tree-sitter website, but they don't discuss the possibility of insertion, and they don't discuss implications for incremental parsing. > Or is it an improvement that should be explored? Yes. > Has this been discussed in the wider tree-sitter community? I would > be surprised if emacs is the first to encounter this weakness. I raised it a couple times; the only response I got was "tree-sitter has excellent error correction". Perhaps other users of tree-sitter don't use it for indenting complex languages. --=20 -- Stephe