From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68824: treesitter support for outline-minor-mode Date: Mon, 12 Feb 2024 20:16:47 +0200 Organization: LINKOV.NET Message-ID: <864jedy2cw.fsf@mail.linkov.net> References: <86le8667u7.fsf@mail.linkov.net> <865xza39vp.fsf@gnu.org> <86y1c6q7oh.fsf@mail.linkov.net> <86mssbbdz5.fsf@mail.linkov.net> <86zfwbwe7a.fsf@gnu.org> <86v86z9e4u.fsf@mail.linkov.net> <86eddmwzs0.fsf@gnu.org> <865xyykvp3.fsf@mail.linkov.net> <86sf21v3rj.fsf@gnu.org> <864jeg8dch.fsf@mail.linkov.net> <86jznctd6p.fsf@gnu.org> <86le7qykec.fsf@mail.linkov.net> <86cyt2st5g.fsf@gnu.org> <867cj9suso.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Yuan Fu , 68824@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 19:20:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZauR-0004RS-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 19:20:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZauB-0007fj-N1; Mon, 12 Feb 2024 13:19:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZauA-0007fT-RR for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 13:19:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZauA-0000RE-DV for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 13:19:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZauR-0007eF-89 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 13:20:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 18:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68824-submit@debbugs.gnu.org id=B68824.170776197929301 (code B ref 68824); Mon, 12 Feb 2024 18:20:03 +0000 Original-Received: (at 68824) by debbugs.gnu.org; 12 Feb 2024 18:19:39 +0000 Original-Received: from localhost ([127.0.0.1]:47299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZau3-0007cV-A0 for submit@debbugs.gnu.org; Mon, 12 Feb 2024 13:19:39 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZau1-0007bp-GR for 68824@debbugs.gnu.org; Mon, 12 Feb 2024 13:19:37 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 73DAEE0008; Mon, 12 Feb 2024 18:19:13 +0000 (UTC) In-Reply-To: <867cj9suso.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Feb 2024 14:59:03 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279911 Archived-At: >> >>> Then maybe just move the text about outline-search-function to the >> >>> place where you describe treesit-outline-predicate? >> >> >> >> 'outline-search-function' is unsuitable for "Tree-sitter Major Modes". >> > >> > All of this thread clearly indicates otherwise. >> >> The real problem is probably that outline-minor-mode’s api wasn’t >> described in the Elisp manual (Imenu, OTOH, has a node in Elisp >> manual). I think we can create a node for outline in (elisp)Modes (that’s >> where the node for Imenu is). We can start out with only >> outline-search-function in there, and over time populate it with >> outline-level, outline-regexp, etc. > > That'd be fine by me. But since Juri said he was uncomfortable with > such a short node, I tried to suggest alternative ideas. If having a > short new node is deemed our best option, then let's do that. Ok, let's add a new node. This is now done and pushed to master. Please check if everything is correct.