From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69241: Fixed patch issues Date: Mon, 11 Mar 2024 18:27:09 +0200 Message-ID: <864jdcvin6.fsf@gnu.org> References: <86msr7ye9h.fsf@gnu.org> <86edcgvrp1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13598"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69241@debbugs.gnu.org, joaotavora@gmail.com To: Daniel Pettersson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 11 17:27:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjiVB-0003O2-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Mar 2024 17:27:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjiUs-0000Do-4u; Mon, 11 Mar 2024 12:27:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjiUq-0000DK-Op for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 12:27:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjiUq-0008Tc-Gi for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 12:27:28 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjiVO-0006Ia-DM for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Mar 2024 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69241-submit@debbugs.gnu.org id=B69241.171017447624199 (code B ref 69241); Mon, 11 Mar 2024 16:28:02 +0000 Original-Received: (at 69241) by debbugs.gnu.org; 11 Mar 2024 16:27:56 +0000 Original-Received: from localhost ([127.0.0.1]:41117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjiVH-0006IE-JE for submit@debbugs.gnu.org; Mon, 11 Mar 2024 12:27:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjiVE-0006I1-SM for 69241@debbugs.gnu.org; Mon, 11 Mar 2024 12:27:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjiUb-0008RB-EC; Mon, 11 Mar 2024 12:27:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JjkIoJudH3Qh8QsClQYnVexfgK+/SyW6r2I/QmDinrk=; b=lfQbnoYL0Lmm BgXZzbwAfsRSDKvCQKLoGHG7n2v8k+ooMJYG7l1yYwRwRyoflzesvLDiwV3ySDvzVMRFcb6ztWrIx 9xXYfWHPUXnZ9pcykzdQFWbzlvlc271qbUKxCQtERV43SgcJSNbmmmpMWYW/DOtniBzzG/jzOf6Ud x1pBO2YcTgtEglNboboPB0ZYyafZYfNZZIZksTuKwRIVk4he40iE6yIBpG7LwPIByb3xkgzGoUCN9 rZkBYQUsq4/UvUdArgkJfhL4V2KzYvZJcU3PkBsX+eqmCCK40APlg2+gvxgeC+ESrEyqVbhAlPj8D N/nnhozfxvlYjFAAHW3rig==; In-Reply-To: (message from Daniel Pettersson on Mon, 11 Mar 2024 15:48:02 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281483 Archived-At: > From: Daniel Pettersson > Cc: joaotavora@gmail.com, 69241@debbugs.gnu.org > Date: Mon, 11 Mar 2024 15:48:02 +0100 > > Eli Zaretskii writes: > > > Can't the code activate the timers in reverse order? Then each > > timer--activate will likely compare with just one timer, the first > > one. > > In my patch they do. As all timers are using the same time list and > pushed on timer-list in the correct order. Feels like *I* have pushed > this thread into bikeshedding territory :) Maybe. But then why we are talking about N^2 order, if you already have a way to fix that? > > Timers must fire in the order of their time, so they must be kept > > sorted, or else running the timer functions and removing the timer > > from the list will be much more complex. > > > > Assuming that timers are sorted is not relying on the internals, if > > you ask me. > > Great, what actions do I need to take to move forward with this > maintainership thing? It's basically up to you, but maybe I don't understand what you are asking.