From: Eli Zaretskii <eliz@gnu.org>
To: "Géza Herman" <geza.herman@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Implement fast verisons of json-parse functions
Date: Wed, 20 Mar 2024 05:37:15 +0200 [thread overview]
Message-ID: <864jd14lqs.fsf@gnu.org> (raw)
In-Reply-To: <874jd2rnwj.fsf@gmail.com> (message from Herman, Géza on Tue, 19 Mar 2024 20:50:48 +0100)
> From: Herman, Géza <geza.herman@gmail.com>
> Cc: Géza Herman <geza.herman@gmail.com>,
> emacs-devel@gnu.org
> Date: Tue, 19 Mar 2024 20:50:48 +0100
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > An optional feature I had in mind was conditional compilation,
> > so that
> > users should decide at build time which version they want. But
> > the
> > names and signatures of the functions exposed to Lisp should be
> > the
> > same in both cases, so that Lisp programmers don't need to
> > change
> > their programs to cater to both alternatives.
> >
> > Apologies if what I wrote was not clear enough about that. For
> > the
> > future, I suggest that we discuss the practical implication of
> > significant changes before you go ahead and invest many hours in
> > implementing and testing them. I would like to avoid situations
> > where
> > you invest significant efforts based on misunderstandings.
>
> Thank you for the great attitude! No worries, it only took ~10
> minutes to create that version. And even if we don't want to have
> that approach, it can still be useful for validation (comparing
> the parsing results of the original and new parser) and
> benchmarking purposes.
>
> If we want to have conditional compilation, is there a simple
> similar conditional compilation case already in Emacs? So I can
> copy the approach easily (supposedly I need to add a flag to
> configure, it needs to add a -DUSE_OWN_JSON_PARSER switch to the
> compiller, etc.)
Let's wait with this until we have a clear idea whether we need this.
My suggestion was just to present a possibility, not necessarily a
decision that we should have this. I'm not sure yet whether we need
to offer the possibility of using libjansson for parsing JSON as an
option.
next prev parent reply other threads:[~2024-03-20 3:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 18:23 [PATCH] Implement fast verisons of json-parse functions Herman, Géza
2024-03-19 18:47 ` Eli Zaretskii
2024-03-19 18:50 ` Herman, Géza
2024-03-19 19:28 ` Eli Zaretskii
2024-03-19 19:50 ` Herman, Géza
2024-03-20 3:37 ` Eli Zaretskii [this message]
2024-03-23 10:40 ` Herman, Géza
2024-03-23 11:11 ` Eli Zaretskii
2024-03-30 7:43 ` Eli Zaretskii
2024-03-30 10:50 ` Herman, Géza
2024-03-30 13:00 ` Eli Zaretskii
2024-03-30 18:36 ` Herman, Géza
2024-03-30 20:18 ` [External] : " Drew Adams
2024-03-30 20:51 ` Herman, Géza
2024-03-30 23:28 ` Drew Adams
2024-03-31 5:08 ` Eli Zaretskii
2024-03-31 14:51 ` Mattias Engdegård
2024-03-31 15:44 ` Eli Zaretskii
2024-04-01 8:48 ` Mattias Engdegård
2024-04-01 16:54 ` Herman, Géza
2024-03-31 17:48 ` Adam Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jd14lqs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=geza.herman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.