From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69942: 30.0.50; Fontification of radio-button widget labels Date: Fri, 22 Mar 2024 17:33:44 +0200 Message-ID: <864jcy1dt3.fsf@gnu.org> References: <87frwinw9c.fsf@rub.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6096"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69942@debbugs.gnu.org To: Stephen Berman , Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 22 16:34:52 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rnguy-0001KS-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Mar 2024 16:34:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnguZ-0000zm-EQ; Fri, 22 Mar 2024 11:34:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnguU-0000yD-H4 for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2024 11:34:23 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rnguT-0007Tw-SQ for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2024 11:34:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rngv8-0003F7-F5 for bug-gnu-emacs@gnu.org; Fri, 22 Mar 2024 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69942 X-GNU-PR-Package: emacs Original-Received: via spool by 69942-submit@debbugs.gnu.org id=B69942.171112169112429 (code B ref 69942); Fri, 22 Mar 2024 15:35:02 +0000 Original-Received: (at 69942) by debbugs.gnu.org; 22 Mar 2024 15:34:51 +0000 Original-Received: from localhost ([127.0.0.1]:60880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rngux-0003EL-F5 for submit@debbugs.gnu.org; Fri, 22 Mar 2024 11:34:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnguv-0003E1-Mw for 69942@debbugs.gnu.org; Fri, 22 Mar 2024 11:34:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnguB-0007Nc-Li; Fri, 22 Mar 2024 11:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iovPmN0JMpynG6QQsIsayFc6NnSeFKwXetgBltEKb6s=; b=bvE2UERCF2DO /KlZUrSPHT8wy+UEsK4xiYANd+dniqOEGY35g281eFfwj6a6UpqihI8K/1D64lyVftry0/NbjC6mR T5YfR5ks6DOEyU9X5EFrOELWASbzETN5p6juqFjVMY4YE91xrEzNudLtNBL9xWKqWNhDFHbcHEXQD mq75NaNTKFI5PEtgljdaIn7ny40CwJmmo/eX6HRaHv8KG5R1iiPNp2vcvESAiRX+TdpTB2JP2AS0n gbW3FwHC0s61GBBcYCQ5EX7vEmR8RpX5lwbIxBA+gKuESs+wMU5oozQYI9fP54u9GcVUe17/7H040 +Z8eLNPBikNHcTVwl+yYgw==; In-Reply-To: <87frwinw9c.fsf@rub.de> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281947 Archived-At: > Date: Fri, 22 Mar 2024 16:04:15 +0100 > From: Stephen Berman via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In bug#69941 I reported a faulty fontification of radio-button widgets > and noted in passing that the labels associated with the radio buttons > also have unexpected faces, namely, the widget-inactive face regardless > of whether the associated radio buttons are inactive or active (except > for the label of a radio button that has been pressed, which has the > default face). While the faulty fontification discussed in bug#69941 > appears to be a real bug, the widget-inactive face assigned to > radio-button labels is apparently by design -- it was present in the > initial commit of the widget library. But this seems to me to have been > a UX mistake, since it effectively ignores the semantics implied by the > name widget-inactive. I think a less surprising UI would be for the > labels to be fontified according to the widget's activation state: > default face when the widget is active and widget-inactive face when > it's inactive. The attached patches provide two possible > implementations of this UI. > > The first patch makes the change unconditionally, treating the current > fontification as a UI/UX bug. But it may be argued that this aspect of > the widget UI should not be unconditionally changed, since it was > apparently a deliberate design choice and there have been (AFAIK) no > complaints about the semantic discrepancy till now. The lack of > complaint could be because the widget-inactive face inherits the shadow > face, so it is not sharply different from the default face. But if one > uses a very different face (as I did for illustrative purposes in > bug#69941), the inconsistency is very obvious and (IMO) jarring. > Nevertheless, to allow keeping the current fontification, the second > patch conditionalizes the change from the current fontification by means > of a user option (with the default being the current fontification). > > Is either of these changes acceptable? Adding Mauro to the discussion.