From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Scheme-mode: Add support for regular expression literal Date: Sat, 30 Mar 2024 10:59:16 +0300 Message-ID: <864jcoduaz.fsf@gnu.org> References: <87msqpfz68.fsf@niceume.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4445"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, jcubic@onet.pl To: "Toshi Umehara" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 30 09:01:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqTee-0000yI-HV for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Mar 2024 09:01:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqTck-0000Ty-25; Sat, 30 Mar 2024 03:59:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqTca-0000T5-Eg for emacs-devel@gnu.org; Sat, 30 Mar 2024 03:59:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqTcW-0000M1-LJ; Sat, 30 Mar 2024 03:59:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ss+A2YgEB7MJDLnAGFncFdImq4LcCEwvAUXqNl3o+jA=; b=cgEUQLlNo5q0 BYmmWLi7DQJ7ntQPGCjAHiKo88NvLRcXTlx3N+T0f3W91YlRjdXUBbW1F/bCb9c/fb4rN9rgWEaO3 YMfEiYvqGkpeFpIeBSUZM3PpMUVIv9wxFU4F34qEXDlVY8tlWtSRYu4IWg+D+QJpKjcCYT4sMwM9L DeLjr2dnOW4BC8tJQrBut2IYQddcbZyw7JToG92iKx2WnG3/RhldDhjVANfq0PFZzCLiHbBk/7aV+ fam282rUGpBGQsO/Q97J6gdlzTAEsvhi3uykDA80Fga+RyuLmchFwGXKvNTH3N3IeHSySkoUN1ZOo klh+XnQNbGCjiBT4o7EKMg==; In-Reply-To: (toshi@niceume.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317385 Archived-At: > Date: Sun, 24 Mar 2024 13:33:19 +0900 > From: "Toshi Umehara" > Cc: emacs-devel@gnu.org, "Eli Zaretskii" , jcubic@onet.pl > > Thank you very much for reviewing the patch, Stefan. > > The patch is updated. > > - Subexpression 1 is now used for regular expression rule in > syntax-propertize-rules > > - Unused arguments are removed from caller and callee of > scheme-syntax-propertize-regexp > > - Changing the third argument of re-search-forward from t to 'move moves > the point to end if the search does not find closing slash, which is > ideal. > > Attached patches are separated into three. The first one changes only > regular expression part mentioned above. The second one is NEWS update. > The third one removes unused arguments also for > scheme-syntax-propertize-sexp-comment . Please use them as you want. Stefan, any further comments? Or should I install this? My only comment is that removing the unused argument from scheme-syntax-propertize-sexp-comment constitutes a change in a public API, so maybe we should not do that.