Re: [PATCH] Scheme-mode: Add support for regular expression literal

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sun, 24 Mar 2024 13:33:19 +0900
> From: "Toshi Umehara" <toshi@niceume.com>
> Cc: emacs-devel@gnu.org, "Eli Zaretskii" <eliz@gnu.org>, jcubic@onet.pl
> 
> Thank you very much for reviewing the patch, Stefan.
> 
> The patch is updated.
> 
> - Subexpression 1 is now used for regular expression rule in
>   syntax-propertize-rules
> 
> - Unused arguments are removed from caller and callee of
>   scheme-syntax-propertize-regexp
>   
> - Changing the third argument of re-search-forward from t to 'move moves
>   the point to end if the search does not find closing slash, which is
>   ideal.
> 
> Attached patches are separated into three. The first one changes only
> regular expression part mentioned above. The second one is NEWS update.
> The third one removes unused arguments also for
> scheme-syntax-propertize-sexp-comment . Please use them as you want.

Stefan, any further comments?  Or should I install this?

My only comment is that removing the unused argument from
scheme-syntax-propertize-sexp-comment constitutes a change in a public
API, so maybe we should not do that.