From: Juri Linkov <juri@linkov.net>
To: Adam Porter <adam@alphapapa.net>
Cc: 70086@debbugs.gnu.org
Subject: bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties
Date: Mon, 06 May 2024 19:46:57 +0300 [thread overview]
Message-ID: <864jbaubum.fsf@mail.linkov.net> (raw)
In-Reply-To: <cd55aa40-1101-4461-9b21-789f4eca732b@alphapapa.net> (Adam Porter's message of "Fri, 3 May 2024 23:15:03 -0500")
close 70086 30.0.50
thanks
>> Could you please distill this example into a self-contained test case
>> like you did the previous time, that helped a lot.
>
> Ok, the following code seems to demonstrate the problem, with your patch
> applied to tab-bar.el:
> [...]
> Enable both tab-bar-ecm-mode and tab-bar-ecm-mode2. Then you'll see that,
> regardless of which lighter is clicked in the tab-bar, the lighter for the
> mode that was activated last catches the mouse clicks for both lighters.
Thanks for the comprehensive test case.
So this feature is now implemented by the following patch and pushed:
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index 2e3d9a6b4ac..26023f24389 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -1119,7 +1119,9 @@ tab-bar-format-global
then modes that display information on the mode line
using `global-mode-string' will display the same text
on the tab bar instead."
- `((global menu-item ,(format-mode-line global-mode-string) ignore)))
+ (mapcar (lambda (string)
+ `(global menu-item ,(format-mode-line string) ignore))
+ global-mode-string))
prev parent reply other threads:[~2024-05-06 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 2:25 bug#70086: Mouse clicks in tab-bar don't call commands bound in keymap properties Adam Porter
2024-03-30 18:16 ` Juri Linkov
2024-03-30 18:56 ` Eli Zaretskii
2024-03-31 16:15 ` Adam Porter
2024-04-05 16:29 ` Juri Linkov
2024-04-05 18:41 ` Adam Porter
2024-04-10 6:42 ` Juri Linkov
2024-05-02 17:55 ` Juri Linkov
2024-05-03 5:45 ` Adam Porter
2024-05-03 6:18 ` Juri Linkov
2024-05-04 4:15 ` Adam Porter
2024-05-05 6:49 ` Juri Linkov
2024-05-06 16:46 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jbaubum.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=70086@debbugs.gnu.org \
--cc=adam@alphapapa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.