From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 61549@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca,
alex@bochannek.com
Subject: bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions
Date: Mon, 03 Jun 2024 14:33:20 +0300 [thread overview]
Message-ID: <864jaamfb3.fsf@gnu.org> (raw)
In-Reply-To: <87h6eahqcd.fsf@web.de> (message from Michael Heerdegen on Mon, 03 Jun 2024 01:33:54 +0200)
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: Eli Zaretskii <eliz@gnu.org>, larsi@gnus.org,
> monnier@iro.umontreal.ca, 61549@debbugs.gnu.org
> Date: Mon, 03 Jun 2024 01:33:54 +0200
>
> Alex Bochannek <alex@bochannek.com> writes:
>
> > I hope this is the last iteration, but please let me know if there are
> > stylistic or implementation issues.
>
> Sorry, but some more small questions from my side (please excuse my
> ignorance, I'm not a heavy user of keyboard macros so if any question
> doesn't make sense maybe I'm just on a wrong track):
Thanks, but please in the future try to chime in earlier, while the
patches are still being discussed. I intentionally wait for at least
a week before doing something, and in this case the thread was going
on for much longer.
> (1) "kmacro-add-counter" and related functions... I wonder why these are
> not named "kmacro-increase-counter" - would that not be better
> understandable? I mean, AFAIU, you do not add a counter but add
> something to an (or "the") counter. But maybe I misunderstand.
If we want to rename this, IMO kmacro-add-to-counter is a better name.
> (2) `kmacro-reg-load-counter': I think I would expect a `user-error'
> being raised when the operation fails. Unless that would get in the
> way in your use case (break recording or so, dunno).
No opinion here, as I don't use those, either.
> (3) I actually don't understand the usage of the
> `kmacro-reg-add-counter-*' named functions (did you, Eli?). An example
> would maybe help.
Did you read the doc string before or after I install the changes?
> In addition I want to say the suggested manual additions are useful.
> Would it make sense to add at least some parts to the file header or
> some pieces to the docstrings, or as comments?
No, I think these are sufficiently obscure to not be in the manual.
next prev parent reply other threads:[~2024-06-03 11:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 8:17 bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions Alex Bochannek
2023-02-17 8:13 ` Eli Zaretskii
2023-02-19 1:59 ` Alex Bochannek
2023-02-19 6:54 ` Eli Zaretskii
2023-03-06 3:37 ` Alex Bochannek
2023-03-11 8:49 ` Eli Zaretskii
2023-03-12 0:19 ` Michael Heerdegen
2024-05-22 23:57 ` Alex Bochannek
2024-05-23 5:36 ` Eli Zaretskii
2024-06-01 0:19 ` Alex Bochannek
2024-06-02 6:01 ` Eli Zaretskii
2024-06-02 23:33 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 11:33 ` Eli Zaretskii [this message]
2024-06-04 0:56 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 1:40 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 2:01 ` Alex Bochannek
2024-06-05 13:52 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 19:07 ` Alex Bochannek
2024-06-08 13:45 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-11 3:06 ` Alex Bochannek
2024-06-08 2:18 ` Pranshu
2024-06-04 14:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jaamfb3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61549@debbugs.gnu.org \
--cc=alex@bochannek.com \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.