From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71638: 30.0.50; Compilation warnings Date: Thu, 20 Jun 2024 18:48:16 +0300 Message-ID: <864j9nobsv.fsf@gnu.org> References: <86jzilp3rz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 71638@debbugs.gnu.org To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 17:49:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKK2E-0004ev-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 17:49:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKK1z-0003hs-Uy; Thu, 20 Jun 2024 11:48:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKK1y-0003hU-Hx for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 11:48:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKK1y-0004cr-9h for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 11:48:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKK22-0005SV-5Y for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71638 X-GNU-PR-Package: emacs Original-Received: via spool by 71638-submit@debbugs.gnu.org id=B71638.171889851320913 (code B ref 71638); Thu, 20 Jun 2024 15:49:02 +0000 Original-Received: (at 71638) by debbugs.gnu.org; 20 Jun 2024 15:48:33 +0000 Original-Received: from localhost ([127.0.0.1]:34083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKK1Y-0005RE-Lq for submit@debbugs.gnu.org; Thu, 20 Jun 2024 11:48:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKK1V-0005Qu-MJ for 71638@debbugs.gnu.org; Thu, 20 Jun 2024 11:48:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKK1L-0004ZS-DU; Thu, 20 Jun 2024 11:48:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B8DGOy3wJnFUICDVK2BXhyybfMqbie7Xgxb5gUxLQIY=; b=FZxaNqj+2Y2ur9vHO9ix U1GjNOom77BIxlotfUNhGi/u7DPfN1kmEp+7+Nf2rliXXwq8tGxA53O+LTPVTKgLiNK6WSQY+Nt88 0Z3vf6FGgMPcJSjQHpRH0UN9yb0nd87A/7+Q5oWkAi7DD2Xq80lPNT9pRxjARGM0cR7VrwuOuDLBi U6LxC/uyulHXyO/hTc+OxSdKik/ZQZyoik+N9BWXaJYZsXDcanemx9FJAzYKXdBpIGj6fyZN3x1nd DAKNKnZQdLN17DTXRv3Fw3zQXWBz4EKBs99J9JP5yjmM6isKcXoYoYu4EmgDn8v/Z61FYjU/06HwY IIFI90+eA4tzRg==; In-Reply-To: (message from Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= on Thu, 20 Jun 2024 15:24:19 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287565 Archived-At: > From: Rudolf Adamkovič > Cc: Po Lu , 71638@debbugs.gnu.org > Date: Thu, 20 Jun 2024 15:24:19 +0200 > > Eli Zaretskii writes: > > > Thanks, I tried to fix that now on master. > > All warnings are gone *except* this one: > > xwidget.c:492:17: warning: variable 'f' set but not used > struct frame *f = NULL; > ^ Sorry, this one you will have to live with: the setting of 'f' is part of checking the validity of the function's arguments, so it must be left alone. > Also, CC'in Po Lu, as after his 'cebca072c33', I *cannot build*: > > CC nsxwidget.o > nsfns.m:1320:3: error: use of undeclared identifier 'image_cache_refcount' > image_cache_refcount = > ^ > nsfns.m:3025:3: error: use of undeclared identifier 'image_cache_refcount' > image_cache_refcount = > ^ > 2 errors generated. Please try again, I think this was fixed meanwhile. > > In the future, please try to fix this on your system, because that's > > the best place to make sure the changes indeed eliminate the warnings. > > Honestly, I did not want to risk wasting more of your time that way. It's the other way around, actually.